New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't notify observers unless the value actually changed. #31

Merged
merged 1 commit into from May 18, 2016

Conversation

Projects
None yet
2 participants
@burrows
Copy link
Member

burrows commented May 17, 2016

Currently setting a prop to an equal value notifies observers. This usually leads to unnecessary work being done in the observer. This change simply ensures that the value is actually different before notifying observers.

@burrows

This comment has been minimized.

Copy link
Member

burrows commented May 17, 2016

@peterwmwong Please take a look when you get a chance.

@peterwmwong

This comment has been minimized.

Copy link
Contributor

peterwmwong commented May 17, 2016

LGTM

@burrows burrows merged commit e1a7588 into master May 18, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment