New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix React mixin to handle manual property change notifications #38

Merged
merged 1 commit into from Jul 22, 2016

Conversation

Projects
None yet
2 participants
@burrows
Copy link
Member

burrows commented Jul 21, 2016

Notifying a property change manually via the Transis.Object#notify method would not trigger an update to a React component observing the prop because the update queue was getting cleared at the beginning of the flush cycle. Notifying a prop change manually happens outside of a flush cycle so the update was never getting processed. The fix was to not clear the update log in the pre-flush callback and instead clear it in the post-flush callback.

@burrows

This comment has been minimized.

Copy link
Member

burrows commented Jul 21, 2016

@mswieboda

This comment has been minimized.

Copy link
Contributor

mswieboda commented Jul 21, 2016

👍

@burrows burrows merged commit 8a8d33b into master Jul 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment