New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes inability of subclasses to load associations #54

Merged
merged 2 commits into from Aug 15, 2018

Conversation

Projects
None yet
2 participants
@alexraginskiy
Copy link
Contributor

alexraginskiy commented Aug 14, 2018

Fixes a bug in the .load that prevented subclasses from loading associations when passing nested objects.

widget: { id: 'widget1' }
}
]
})

This comment has been minimized.

@burrows

burrows Aug 14, 2018

Member

You're not doing any assertions in these specs. Might want to assert that the associated objects are of the correct class.

This comment has been minimized.

@alexraginskiy

alexraginskiy Aug 14, 2018

Contributor

bah, you're right...I had them setup because those calls were failing prior to this change. will add assertions

@burrows

This comment has been minimized.

Copy link
Member

burrows commented Aug 14, 2018

LGTM.

@alexraginskiy alexraginskiy merged commit c08d003 into master Aug 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment