docker: consolidate ceph-ansible and ceph-docker varible #1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
font
reviewed
Dec 9, 2016
This commit re-uses some of the existing ceph-ansible variables for a containirzed deployment. There is no reasons why we should add new variables for the containerized deployment. Signed-off-by: Sébastien Han <seb@redhat.com>
leseb
force-pushed
the
ceph-ansible-docker-vars
branch
from
1860c46
to
75cb749
Compare
leseb
commented
Dec 9, 2016
| #ceph_mon_docker_username: ceph | ||
| #ceph_mon_docker_imagename: daemon | ||
| #ceph_mon_docker_image_tag: latest | ||
| #ceph_mon_extra_envs: "MON_NAME={{ ansible_hostname }}" # comma separated variables | ||
| #ceph_mon_extra_envs: "FSID={{ fsid }},MON_NAME={{ ansible_hostname }}" # comma separated variables |
There was a problem hiding this comment.
we don't know fsid yet so this won't work, we skip ceph-common...
There was a problem hiding this comment.
This is true, but this variable is really only used for non-CoreOS and non-RedHat based systems. Even then, the FSID or CEPH_FSID environment variables, where ceph_mon_extra_envs is mostly used, aren't even consumed by the entrypoint.
Signed-off-by: Sébastien Han <seb@redhat.com>
For readibility and clarity we do not run any tasks directly in the main.yml file. This file should only contain include, which helps us later to apply conditionnals if we want to. Signed-off-by: Sébastien Han <seb@redhat.com>
leseb
force-pushed
the
ceph-ansible-docker-vars
branch
from
d7e4ac5
to
189f4fe
Compare
andrewschoen
approved these changes
Dec 9, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit re-uses some of the existing ceph-ansible variables for a
containirzed deployment. There is no reasons why we should add new
variables for the containerized deployment.
Signed-off-by: Sébastien Han seb@redhat.com