Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[skip ci] Remove ceph-disk support #3187

Closed
wants to merge 9 commits into from
Closed

[skip ci] Remove ceph-disk support #3187

wants to merge 9 commits into from

Conversation

leseb
Copy link
Member

@leseb leseb commented Oct 2, 2018 •
edited

No description provided.

@leseb leseb added the DNM Do NOT merge label Oct 2, 2018
@leseb leseb added this to the v3.2 milestone Oct 2, 2018
@leseb
Copy link
Member Author

leseb commented Oct 2, 2018 •
edited

This comes on top of: #2866.

TODO:

  • remove ceph-disk code

  • update the doc

  • change restart scripts?

  • update ceph-validate with the change

  • default osd_scenario to 'lvm' and remove it as a mandatory var

  • remove ceph-disk CI tests from upstream

  • update CI tests to use ceph-volume (docker_cluster/centos7 etc)

  • make sure devices and ddedicated_devices work as expected, still

  • how to manage the transition between disks configured with ceph-disk and the new default ceph-volume? How to skip the preparation? How to detect ceph-disk drives since ceph-volume cannot do it yet? In the context of lvm_batch

@leseb leseb changed the title [skip ci] Rm ceph disk support [skip ci] Remove ceph-disk support Oct 2, 2018
@leseb leseb force-pushed the rm-ceph-disk-support branch 2 times, most recently from 324b645 to dcf2517 Compare October 9, 2018 16:44
@leseb leseb mentioned this pull request Oct 10, 2018
Merged
8 tasks
@leseb leseb removed the DNM Do NOT merge label Oct 10, 2018
@leseb leseb changed the title [skip ci] Remove ceph-disk support Remove ceph-disk support Oct 10, 2018
@leseb
Copy link
Member Author

leseb commented Oct 10, 2018

jenkins test pipeline

@leseb
Copy link
Member Author

leseb commented Oct 11, 2018

jenkins test pipeline

@leseb leseb force-pushed the rm-ceph-disk-support branch 4 times, most recently from 5454a75 to ce260a2 Compare October 12, 2018 16:45
leseb added a commit that referenced this pull request Oct 12, 2018
@leseb
test: fix docker test for lvm
6d48ee9 
The CI is still running ceph-disk tests upstream. So until
#3187 is merged nothing will
pass anymore.

Signed-off-by: Sébastien Han <seb@redhat.com>
@leseb leseb mentioned this pull request Oct 12, 2018
Merged
@leseb
Copy link
Member Author

leseb commented Oct 12, 2018

@andrewschoen if you could look at the validate part, that'd be nice, thanks.

leseb added a commit that referenced this pull request Oct 12, 2018
@leseb
test: fix docker test for lvm
c957f90 
The CI is still running ceph-disk tests upstream. So until
#3187 is merged nothing will
pass anymore.

Signed-off-by: Sébastien Han <seb@redhat.com>
@leseb leseb added the DNM Do NOT merge label Oct 12, 2018
@leseb
Copy link
Member Author

leseb commented Oct 12, 2018

jenkins test luminous-centos7_cluster

@leseb
Copy link
Member Author

leseb commented Oct 12, 2018

jenkins test luminous-docker_cluster

@leseb
Copy link
Member Author

leseb commented Oct 12, 2018

jenkins test luminous-docker_cluster_collocation

@leseb
Copy link
Member Author

leseb commented Oct 12, 2018

jenkins test luminous-ooo_collocation

mergify bot pushed a commit that referenced this pull request Oct 12, 2018
@leseb @mergify
test: fix docker test for lvm
fa38b86 
The CI is still running ceph-disk tests upstream. So until
#3187 is merged nothing will
pass anymore.

Signed-off-by: Sébastien Han <seb@redhat.com>
@leseb
Copy link
Member Author

leseb commented Oct 16, 2018

jenkins test luminous-centos7_cluster

@leseb
Copy link
Member Author

leseb commented Oct 16, 2018

jenkins test luminous-docker_cluster

@leseb
Copy link
Member Author

leseb commented Oct 16, 2018

jenkins test luminous-docker_cluster_collocation

This was referenced Oct 18, 2018
Closed
Closed
Merged
@guits guits mentioned this pull request Oct 25, 2018
Merged
@leseb leseb mentioned this pull request Oct 26, 2018
Merged
@leseb leseb modified the milestones: v3.2, v3.3 Oct 30, 2018
@leseb leseb changed the title Remove ceph-disk support [skip ci] Remove ceph-disk support Nov 12, 2018
@leseb
osd: remove ceph-disk support
e7b81c0 
We don't support the preparation of OSD with ceph-disk. ceph-volume is
only supported. However, the start operation of OSD is still supported.
So let's say you change a config option, the handlers will be able to
restart all the OSDs via their respective systemd unit files.

Signed-off-by: Sébastien Han <seb@redhat.com>
@leseb
validate: print a message for old scenarios
cf6a71f 
ceph-disk is not supported anymore, so all the newly created OSDs will
be configured using ceph-volume.

Signed-off-by: Sébastien Han <seb@redhat.com>
@leseb
osd: default osd_scenario to lvm
75008ae 
osd_scenario has become obsolete and defaults to lvm. With lvm there is
no such things has collocated and non-collocated.

Signed-off-by: Sébastien Han <seb@redhat.com>
@leseb
doc: update osd scenario
078dc76 
This commits adds documentation for the lvm scenario and the deprecation
of collocated and non-collocated scenario.

Signed-off-by: Sébastien Han <seb@redhat.com>
@leseb
plugin: validate lint
4606d32 
Make python linter happy.

Signed-off-by: Sébastien Han <seb@redhat.com>
@leseb
plugin: validate.py do not check osd_scenario
0f64ba5 
osd_scenario now defaults to lvm and should not be changed. So we don't
need to test it.

Signed-off-by: Sébastien Han <seb@redhat.com>
@leseb
validate: only check device when they are devices
ddb3d5f 
We only validate the devices that are passed if there is a list of
devices to validate.

Signed-off-by: Sébastien Han <seb@redhat.com>
@leseb
tests: remove uncessary test_osds condition
0f79fb3 
Now that we have ceph-volume by default, systemd unit are named such
ceph-osd@0 thus we abandonned the ceph-osd@sda format.

Signed-off-by: Sébastien Han <seb@redhat.com>
@leseb
validate: remove osd_auto_discovery
1bf7a3c 
Since we switched to ceph-volume only we do not support
osd_auto_discovery scenario anymore.

Signed-off-by: Sébastien Han <seb@redhat.com>
@guits
Copy link
Collaborator

guits commented Apr 1, 2019

this PR needs to be resurrected

@guits guits mentioned this pull request Apr 1, 2019
Closed
@guits guits mentioned this pull request Apr 11, 2019
Closed
@dsavineau
Copy link
Contributor

this has been done in #3837

@dsavineau dsavineau closed this Apr 12, 2019
@dsavineau dsavineau deleted the rm-ceph-disk-support branch September 6, 2019 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewschoen andrewschoen andrewschoen left review comments

Assignees
No one assigned
Labels
DNM Do NOT merge
Projects
None yet
Milestone
v4.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@leseb @guits @dsavineau @andrewschoen