Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup_ntp: call handler to disable ntpd if chronyd used #3583

Merged
merged 2 commits into from Feb 8, 2019

Conversation

Projects
None yet
3 participants
@pcfe
Copy link
Contributor

commented Feb 7, 2019

The task setup chronyd called the handler disable chronyd, which of
course defeats the purpose.

Changing the task to disable ntpd instead fixes the issue of chronyd
being disabled after it got enabled.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1673664
Fixes: #3582

Signed-off-by: Patrick C. F. Ernzer pcfe@redhat.com

pcfe added some commits Feb 7, 2019

setup_ntp: call handler to disable ntpd if chronyd used
The task setup chronyd called the handler disable chronyd, which of
course defeats the purpose.

Changing the task to disable ntpd instead fixes the issue of chronyd
being disabled after it got enabled.

Fixes: #3582

Signed-off-by: Patrick C. F. Ernzer pcfe@redhat.com
@leseb

leseb approved these changes Feb 8, 2019

Copy link
Contributor

left a comment

Good catch thanks.

@leseb leseb merged commit c605ff6 into ceph:master Feb 8, 2019

3 of 4 checks passed

Mergify — Rule: automatic merge (merge) The rule doesn't match anymore, this action has been cancelled
Details
Mergify — Summary 1 rule matches and 3 potential rules
Details
Testing: ceph-ansible PR Pipeline OK - ceph-ansible PR Pipeline
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pcfe pcfe deleted the pcfe:pcfe-fix-chronyd-use branch Feb 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.