Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow adding a manager to a deployed cluster #3931

Merged
merged 2 commits into from May 7, 2019
Merged

allow adding a manager to a deployed cluster #3931

merged 2 commits into from May 7, 2019

Conversation

rishabh-d-dave
Copy link
Contributor

Add a playbook that deploys manager on a new node and adds that node to
the already deployed Ceph cluster.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1677431
Signed-off-by: Rishabh Dave ridave@redhat.com

@rishabh-d-dave
Copy link
Contributor Author

This PR covers both containerized and non-containerized deployment. Locally it ran successfully; I have attached the logs to this comment.
dev-centos-container-add_mgrs-SUCCEEDED.log
dev-centos-non_container-add_mgrs-SUCCEEDED.log

@rishabh-d-dave
Copy link
Contributor Author

@guits @dsavineau I've named the new node as mgr0. But should it be named as mgr1 considering that one MGR is already deployed at mon0?

@rishabh-d-dave
Copy link
Contributor Author

jenkins test dev-centos-non_container-add_mgrs

@rishabh-d-dave
Copy link
Contributor Author

jenkins test dev-centos-container-add_mgrs

@dsavineau
Copy link
Contributor

@guits @dsavineau I've named the new node as mgr0. But should it be named as mgr1 considering that one MGR is already deployed at mon0?

I don't think this need to be mgr1. Even if there's already a mgr node collocated on mon0, the first mgr node (dedicated) should be named mgr0

@rishabh-d-dave
Copy link
Contributor Author

jenkins test dev-centos-non_container-all_daemons

@rishabh-d-dave
Copy link
Contributor Author

jenkins test pipeline

@rishabh-d-dave
Copy link
Contributor Author

jenkins test dev-centos-container-update

@rishabh-d-dave rishabh-d-dave force-pushed the add-mgr branch 4 times, most recently from cb1854b to 0b26e9f Compare May 7, 2019 10:41
@guits guits changed the title allow adding a manager to a deployed cluster [skip ci] allow adding a manager to a deployed cluster May 7, 2019
@guits guits added the DNM Do NOT merge label May 7, 2019
@guits guits changed the title [skip ci] allow adding a manager to a deployed cluster allow adding a manager to a deployed cluster May 7, 2019
@guits
Copy link
Collaborator

guits commented May 7, 2019

jenkins test dev-centos-non_container-lvm_osds

@guits
Copy link
Collaborator

guits commented May 7, 2019

jenkins test dev-centos-container-lvm_osds

@guits
Copy link
Collaborator

guits commented May 7, 2019

jenkins test dev-centos-container-add_mgrs

@guits
Copy link
Collaborator

guits commented May 7, 2019

jenkins test dev-centos-non_container-add_mgrs

@guits guits changed the title allow adding a manager to a deployed cluster [skip ci] allow adding a manager to a deployed cluster May 7, 2019
@rishabh-d-dave
allow adding a manager to a deployed cluster
8f469e9 
Add a playbook that deploys manager on a new node and adds that node to
the already deployed Ceph cluster.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1677431
Signed-off-by: Rishabh Dave <ridave@redhat.com>
@rishabh-d-dave
ceph-mgr: create keys for MGRs
b464646 
Add code in ceph-mgr for creating a keyring for manager in so that
managers can be deployed on a separate node too.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
@rishabh-d-dave rishabh-d-dave changed the title [skip ci] allow adding a manager to a deployed cluster allow adding a manager to a deployed cluster May 7, 2019
@rishabh-d-dave
Copy link
Contributor Author

jenkins test dev-centos-non_container-add_mgrs

@rishabh-d-dave
Copy link
Contributor Author

jenkins test dev-centos-container-add_mgrs

@rishabh-d-dave rishabh-d-dave changed the title allow adding a manager to a deployed cluster [skip ci]allow adding a manager to a deployed cluster May 7, 2019
@guits guits changed the title [skip ci]allow adding a manager to a deployed cluster allow adding a manager to a deployed cluster May 7, 2019
@guits guits removed the DNM Do NOT merge label May 7, 2019
@guits guits merged commit 56bfec7 into ceph:master May 7, 2019
@mergify mergify bot mentioned this pull request May 7, 2019
Merged
@rishabh-d-dave rishabh-d-dave deleted the add-mgr branch December 12, 2019 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guits guits guits approved these changes

@dsavineau dsavineau Awaiting requested review from dsavineau

Assignees
No one assigned
Labels
backport-stable-4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rishabh-d-dave @dsavineau @guits