Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nfs: support internal ganesha with external ceph cluster #4010

Merged
merged 3 commits into from Jun 3, 2019

Conversation

guits
Copy link
Collaborator

@guits guits commented May 20, 2019

This commits allows to deploy an internal ganesha with an external ceph cluster.

This requires to define external_cluster_mon_ips with a comma
separated list of external monitors.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1710358

Signed-off-by: Guillaume Abrioux gabrioux@redhat.com

@guits guits added the DNM Do NOT merge label May 20, 2019
@guits guits force-pushed the guits-standalone_ganesha branch from 511408b to 87b442c Compare May 20, 2019 14:02
@guits
Copy link
Collaborator Author

guits commented May 20, 2019

container won't start because of this: https://github.com/ceph/ceph-container/blob/master/src/daemon/start_nfs.sh#L20-L23

@guits guits force-pushed the guits-standalone_ganesha branch 2 times, most recently from c70450a to c74627b Compare May 20, 2019 14:38
@gfidente
Copy link
Contributor

I think having to provision the Ganesha client keyring on the ceph-nfs nodes makes perfect sense; I think that can be configured using the "ceph_nfs_ceph_user" variable and provisioned on the node using the "keys" structure (from ceph-client role)? What do you think?

@guits guits changed the title [skip ci] nfs: support internal Ganesha with external ceph cluster [skip ci] nfs: support internal ganesha with external ceph cluster May 21, 2019
@guits guits force-pushed the guits-standalone_ganesha branch 3 times, most recently from 314ade5 to 138465c Compare May 21, 2019 15:26
@guits guits removed the DNM Do NOT merge label May 21, 2019
@guits guits force-pushed the guits-standalone_ganesha branch from 138465c to b295fea Compare May 21, 2019 15:28
@guits
Copy link
Collaborator Author

guits commented May 21, 2019

@gfidente the variable nfs_obj_gw is True by default in ceph-ansible.

the template for ganesha.conf has this code which requires ceph_nfs_rgw_access_key and ceph_nfs_rgw_secret_key to be set.
Usually ceph-ansible generates them itself here
but in this use case, it means they have to be manually set. Is that ok for you?

@guits guits added the DNM Do NOT merge label May 21, 2019
@gfidente
Copy link
Contributor

I think that would be okay ... and in TripleO we only want the MDS FSAL so we disable nfs_obj_gw [1]; do you think things will work when it is disabled?

  1. https://github.com/openstack/tripleo-heat-templates/blob/master/deployment/ceph-ansible/ceph-nfs.yaml#L59

@guits
Copy link
Collaborator Author

guits commented May 22, 2019

@gfidente yes, it will work.

@guits guits force-pushed the guits-standalone_ganesha branch 2 times, most recently from f9a5f88 to 37041ed Compare May 22, 2019 07:53
@guits guits changed the title [skip ci] nfs: support internal ganesha with external ceph cluster fs: support internal ganesha with external ceph cluster May 22, 2019
@guits guits changed the title fs: support internal ganesha with external ceph cluster nfs: support internal ganesha with external ceph cluster May 22, 2019
@guits guits added backport-stable-4.0 and removed DNM Do NOT merge labels May 22, 2019
@guits
Copy link
Collaborator Author

guits commented May 23, 2019

jenkins test pipeline

guits added 2 commits May 23, 2019 14:39
This commits allows to deploy an internal ganesha with an external ceph
cluster.

This requires to define `external_cluster_mon_ips` with a comma
separated list of external monitors.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1710358

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
if `nfs_obj_gw` is True when deploying an internal ganesha with an
external ceph cluster, `ceph_nfs_rgw_access_key` and
`ceph_nfs_rgw_secret_key` must be provided so the
ganesha configuration file can be generated.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
@guits guits force-pushed the guits-standalone_ganesha branch from 5ad911b to b7ea9d7 Compare May 23, 2019 12:39
@guits guits merged commit 003aeea into master Jun 3, 2019
@guits guits deleted the guits-standalone_ganesha branch June 3, 2019 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants