Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

containers: improve logging #4166

Merged
merged 2 commits into from
Jun 28, 2019
Merged

containers: improve logging #4166

merged 2 commits into from
Jun 28, 2019

Conversation

guits
Copy link
Collaborator

@guits guits commented Jun 26, 2019

related ceph-container PR: ceph/ceph-container#1408

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1710548

Signed-off-by: Guillaume Abrioux gabrioux@redhat.com

@guits guits force-pushed the guits-containers_logging branch 2 times, most recently from f08406f to bf516c8 Compare June 26, 2019 13:59
guits added a commit to ceph/ceph-container that referenced this pull request Jun 26, 2019
sosreport does not export logs from journald, so the idea here is to
have an alternative to retrieve logs in a containerized context.

Related ceph-ansible PR: ceph/ceph-ansible#4166

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1710548

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
guits added a commit to ceph/ceph-container that referenced this pull request Jun 26, 2019
sosreport does not export logs from journald, so the idea here is to
have an alternative to retrieve logs in a containerized context.

Related ceph-ansible PR: ceph/ceph-ansible#4166

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1710548

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
guits added a commit to ceph/ceph-container that referenced this pull request Jun 26, 2019
sosreport does not export logs from journald, so the idea here is to
have an alternative to retrieve logs in a containerized context.

Related ceph-ansible PR: ceph/ceph-ansible#4166

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1710548

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
dsavineau pushed a commit to ceph/ceph-container that referenced this pull request Jun 26, 2019
sosreport does not export logs from journald, so the idea here is to
have an alternative to retrieve logs in a containerized context.

Related ceph-ansible PR: ceph/ceph-ansible#4166

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1710548

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
dsavineau pushed a commit to dsavineau/ceph-container that referenced this pull request Jun 26, 2019
sosreport does not export logs from journald, so the idea here is to
have an alternative to retrieve logs in a containerized context.

Related ceph-ansible PR: ceph/ceph-ansible#4166

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1710548

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit d6d1d9c)
dsavineau pushed a commit to ceph/ceph-container that referenced this pull request Jun 26, 2019
sosreport does not export logs from journald, so the idea here is to
have an alternative to retrieve logs in a containerized context.

Related ceph-ansible PR: ceph/ceph-ansible#4166

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1710548

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit d6d1d9c)
@guits guits changed the title [skip ci] containers: improve logging containers: improve logging Jun 27, 2019
@guits guits removed the DNM Do NOT merge label Jun 27, 2019
@guits
Copy link
Collaborator Author

guits commented Jun 27, 2019

jenkins test pipeline

@guits
Copy link
Collaborator Author

guits commented Jun 27, 2019

job failed because of a vagrant error:

dev-ubuntu-container-all_daemons run-test: commands[11] | vagrant destroy --force
[7712] /home/jenkins-build/build/workspace/ceph-ansible-prs-dev-ubuntu-container-all_daemons/tests/functional/all_daemons/container$ /usr/bin/vagrant destroy --force
Error while connecting to libvirt: Error making a connection to libvirt URI qemu:///system?no_verify=1&keyfile=/home/jenkins-build/.ssh/id_rsa:
Call to virConnectOpen failed: authentication failed: access denied by policy

Copy link
Contributor

@dsavineau dsavineau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember if we need the z flag for this bind mount. wdyt ?

bindmount /var/log/ceph on all containers so it's possible to retrieve
logs from the host.

related ceph-container PR: ceph/ceph-container#1408

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1710548

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
@dsavineau
Copy link
Contributor

jenkins test pipeline

2 similar comments
@guits
Copy link
Collaborator Author

guits commented Jun 27, 2019

jenkins test pipeline

@dsavineau
Copy link
Contributor

jenkins test pipeline

@dsavineau
Copy link
Contributor

jenkins test dev-centos-non_container-lvm_auto_discovery

@dsavineau
Copy link
Contributor

unrelated CI failure

@dsavineau dsavineau merged commit 33eed78 into master Jun 28, 2019
@dsavineau dsavineau deleted the guits-containers_logging branch June 28, 2019 17:30
@fultonj
Copy link
Contributor

fultonj commented Aug 28, 2019

@guits can this get backported to 3.x?

isi-lincoln pushed a commit to mergetb/ceph-container that referenced this pull request Sep 14, 2019
sosreport does not export logs from journald, so the idea here is to
have an alternative to retrieve logs in a containerized context.

Related ceph-ansible PR: ceph/ceph-ansible#4166

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1710548

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit d6d1d9c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants