Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

purge: use sysfs to unmap rbd devices #4712

Merged
merged 2 commits into from Nov 8, 2019
Merged

Conversation

guits
Copy link
Collaborator

@guits guits commented Nov 4, 2019

in containerized context, using the binary provided in atomic os won't
work because it's an old version provided by ceph-common based on
10.2.5.
Using a container could be an idea but for large cluster with hundreds
of client nodes, that would require to pull the image of each of them
just to unmap the rbd devices.

Let's use the sysfs method in order to avoid any issue related to ceph
version that is shipped on the host.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1766064

Signed-off-by: Guillaume Abrioux gabrioux@redhat.com

@guits
Copy link
Collaborator Author

guits commented Nov 5, 2019

jenkins test centos-non_container-all_daemons

2 similar comments
@guits
Copy link
Collaborator Author

guits commented Nov 5, 2019

jenkins test centos-non_container-all_daemons

@guits
Copy link
Collaborator Author

guits commented Nov 6, 2019

jenkins test centos-non_container-all_daemons

@guits
Copy link
Collaborator Author

guits commented Nov 6, 2019

jenkins test centos-non_container-update

@guits
Copy link
Collaborator Author

guits commented Nov 6, 2019

jenkins test centos-non_container-switch_to_containers

3 similar comments
@guits
Copy link
Collaborator Author

guits commented Nov 6, 2019

jenkins test centos-non_container-switch_to_containers

@guits
Copy link
Collaborator Author

guits commented Nov 6, 2019

jenkins test centos-non_container-switch_to_containers

@guits
Copy link
Collaborator Author

guits commented Nov 6, 2019

jenkins test centos-non_container-switch_to_containers

@guits
Copy link
Collaborator Author

guits commented Nov 7, 2019

jenkins test centos-container-update

@guits guits force-pushed the guits-rbd_unmap_container branch 2 times, most recently from d413585 to acc0daf Compare November 7, 2019 13:25
@guits
Copy link
Collaborator Author

guits commented Nov 7, 2019

jenkins test centos-non_container-collocation

@guits
Copy link
Collaborator Author

guits commented Nov 7, 2019

jenkins test centos-container-all_daemons

@guits
Copy link
Collaborator Author

guits commented Nov 7, 2019

jenkins test centos-non_container-purge

in containerized context, using the binary provided in atomic os won't
work because it's an old version provided by ceph-common based on
10.2.5.
Using a container could be an idea but for large cluster with hundreds
of client nodes, that would require to pull the image of each of them
just to unmap the rbd devices.

Let's use the sysfs method in order to avoid any issue related to ceph
version that is shipped on the host.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1766064

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
@guits guits force-pushed the guits-rbd_unmap_container branch 8 times, most recently from 322521a to c804fdb Compare November 7, 2019 23:15
@guits
Copy link
Collaborator Author

guits commented Nov 7, 2019

jenkins test centos-non_container-switch_to_containers

This commit adds a playbook to be played before we run purge playbook,
it first creates an rbd image then map an rbd device on client0 so the
purge playbook will try to unmap it.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
@guits
Copy link
Collaborator Author

guits commented Nov 8, 2019

jenkins test centos-non_container-all_daemons

@guits
Copy link
Collaborator Author

guits commented Nov 8, 2019

jenkins test centos-container-all_daemons

@guits
Copy link
Collaborator Author

guits commented Nov 8, 2019

jenkins test centos-non_container-purge

3 similar comments
@guits
Copy link
Collaborator Author

guits commented Nov 8, 2019

jenkins test centos-non_container-purge

@guits
Copy link
Collaborator Author

guits commented Nov 8, 2019

jenkins test centos-non_container-purge

@guits
Copy link
Collaborator Author

guits commented Nov 8, 2019

jenkins test centos-non_container-purge

@dsavineau dsavineau merged commit db77fbd into master Nov 8, 2019
@guits guits deleted the guits-rbd_unmap_container branch November 8, 2019 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants