upgrade: add dashboard deployment (bp #4813) #4825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
when upgrading from RHCS 3, dashboard has obviously never been deployed and it forces us to deploy it later manually. This commit adds the dashboard deployment as part of the upgrade to RHCS 4. Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1779092 Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com> (cherry picked from commit 451c5ca)
In containerized context, containers aren't stopped early in the sequence. It means they aren't restarted after the upgrade because the task is just checking the daemon status is started (eg: `state: started`). This commit also removes the task which ensure services are started because it's already done in the role ceph-iscsigw. Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com> (cherry picked from commit c7708eb)
A recent change in ceph/ceph prevent from having username in the password: `Error EINVAL: Password cannot contain username.` Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com> (cherry picked from commit 0756fa4)
|
jenkins test centos-container-purge |
2 similar comments
|
jenkins test centos-container-purge |
|
jenkins test centos-container-purge |
|
jenkins test centos-container-update |
6 similar comments
|
jenkins test centos-container-update |
|
jenkins test centos-container-update |
|
jenkins test centos-container-update |
|
jenkins test centos-container-update |
|
jenkins test centos-container-update |
|
jenkins test centos-container-update |
|
|
jenkins test centos-container-update |
@mikechristie is this expected ? We don't have gateways defined in our scenarios so during the upgrade from ceph-iscsi 2 to 3 then there's no |
|
It's not expected. For this bug, it is as simple as adding a get(). However, let me do some more testing and code review to make sure we did not add other bugs like that, because based on this bug it looks like we did not test the case of upgrading when nothing is defined. Will post a PR and make a new release for you guys. |
|
@dsavineau we figured out the failure in the CI and we know it's not related to this PR, I propose we merge this PR even though that job isn't passing then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated backport of pull request #4813 done by Mergify.io
Mergify commands and options
More conditions and actions can be found in the [documention](https://doc.mergify.io/).
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio rebasewill rebase this PR@Mergifyio backports <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.io/