Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filestore-to-bluestore: fix osd_auto_discovery #4971

Merged
merged 1 commit into from Jan 22, 2020

Conversation

dsavineau
Copy link
Contributor

When osd_auto_discovery is set then we need to refresh the
ansible_devices fact between after the filestore OSD purge
otherwise the devices fact won't be populated.
Also remove the gpt header on ceph_disk_osds_devices because
the devices is empty at this point for osd_auto_discovery.
Adding the bool filter when needed.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1729267

Signed-off-by: Dimitri Savineau dsavinea@redhat.com

@dsavineau dsavineau requested a review from guits January 21, 2020 22:10
@dsavineau dsavineau changed the title [skip ci] filestore-to-bluestore: fix osd_auto_discovery filestore-to-bluestore: fix osd_auto_discovery Jan 21, 2020
@dsavineau
Copy link
Contributor Author

jenkins test centos-container-filestore_to_bluestore

@dsavineau
Copy link
Contributor Author

jenkins test centos-non_container-filestore_to_bluestore

When osd_auto_discovery is set then we need to refresh the
ansible_devices fact between after the filestore OSD purge
otherwise the devices fact won't be populated.
Also remove the gpt header on ceph_disk_osds_devices because
the devices is empty at this point for osd_auto_discovery.
Adding the bool filter when needed.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1729267

Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
@dsavineau dsavineau changed the title filestore-to-bluestore: fix osd_auto_discovery [skip ci] filestore-to-bluestore: fix osd_auto_discovery Jan 21, 2020
@dsavineau dsavineau changed the title [skip ci] filestore-to-bluestore: fix osd_auto_discovery filestore-to-bluestore: fix osd_auto_discovery Jan 21, 2020
@dsavineau
Copy link
Contributor Author

jenkins test centos-container-filestore_to_bluestore

@dsavineau
Copy link
Contributor Author

jenkins test centos-non_container-filestore_to_bluestore

@guits guits merged commit bb3eae0 into ceph:master Jan 22, 2020
@dsavineau dsavineau deleted the BZ1729267 branch January 22, 2020 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants