common: support OSDs with more than 2 digits #5087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guits
changed the title
|
jenkins test centos-container-purge |
guits
changed the title
guits
force-pushed
the
guits-purge_support_osds_3_digits
branch
from
7948d3b
to
7cd0320
Compare
guits
changed the title
|
jenkins test centos-container-purge |
guits
changed the title
guits
force-pushed
the
guits-purge_support_osds_3_digits
branch
from
7cd0320
to
8813342
Compare
guits
changed the title
|
jenkins test centos-container-purge |
|
What happens when we get to four digits? |
We make a new PR 😆 joke aside, a refact of this patch is in progress to address this issue. |
guits
changed the title
guits
force-pushed
the
guits-purge_support_osds_3_digits
branch
from
8813342
to
0b42a38
Compare
When running environment with OSDs having ID with more than 2 digits, some tasks don't match the system units and therefore, playbook can fail. Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1805643 Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
guits
force-pushed
the
guits-purge_support_osds_3_digits
branch
from
0b42a38
to
e19574c
Compare
guits
changed the title
|
jenkins test centos-container-purge |
|
jenkins test centos-non_container-purge |
|
jenkins test centos-container-update |
|
jenkins test centos-non_container-update |
|
jenkins test centos-non_container-switch_to_containers |
|
jenkins test centos-non_container-all_daemons |
|
jenkins test centos-container-all_daemons |
guits
changed the title
guits
changed the title
dsavineau
approved these changes
Feb 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
purge-container-cluster: support OSDs with 3 digits
When running environment with OSDs having ID with more than 2 digits,
this task doesn't match the system units and therefore, fails the playbook.
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1805643
Signed-off-by: Guillaume Abrioux gabrioux@redhat.com