Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filestore-to-bluestore: reuse dedicated journal (bp #5034) #5094

Merged
merged 2 commits into from Mar 12, 2020

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Feb 25, 2020

This is an automated backport of pull request #5034 done by Mergify.io

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR
  • @Mergifyio backports <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the simulator.

Finally, you can contact us on https://mergify.io/

@dsavineau dsavineau changed the title filestore-to-bluestore: reuse dedicated journal (bp #5034) [skip ci] filestore-to-bluestore: reuse dedicated journal (bp #5034) Feb 25, 2020
@dsavineau dsavineau changed the title [skip ci] filestore-to-bluestore: reuse dedicated journal (bp #5034) filestore-to-bluestore: reuse dedicated journal (bp #5034) Feb 25, 2020
@dsavineau
Copy link
Contributor

jenkins test centos-non_container-filestore_to_bluestore

@dsavineau
Copy link
Contributor

jenkins test centos-container-filestore_to_bluestore

@guits
Copy link
Collaborator

guits commented Feb 26, 2020

jenkins test centos-non_container-filestore_to_bluestore

2 similar comments
@dsavineau
Copy link
Contributor

jenkins test centos-non_container-filestore_to_bluestore

@dsavineau
Copy link
Contributor

jenkins test centos-non_container-filestore_to_bluestore

@dsavineau dsavineau added this to the v4.1 milestone Mar 2, 2020
@dsavineau
Copy link
Contributor

jenkins test centos-non_container-filestore_to_bluestore

1 similar comment
@guits
Copy link
Collaborator

guits commented Mar 3, 2020

jenkins test centos-non_container-filestore_to_bluestore

@dsavineau dsavineau changed the title filestore-to-bluestore: reuse dedicated journal (bp #5034) [skip ci] filestore-to-bluestore: reuse dedicated journal (bp #5034) Mar 5, 2020
@dsavineau dsavineau force-pushed the mergify/bp/stable-4.0/pr-5034 branch from deb42a0 to ef8b90e Compare March 5, 2020 22:54
@dsavineau dsavineau changed the title [skip ci] filestore-to-bluestore: reuse dedicated journal (bp #5034) filestore-to-bluestore: reuse dedicated journal (bp #5034) Mar 5, 2020
@dsavineau
Copy link
Contributor

jenkins test centos-non_container-filestore_to_bluestore

@dsavineau
Copy link
Contributor

jenkins test centos-container-filestore_to_bluestore

@dsavineau
Copy link
Contributor

jenkins test centos-non_container-filestore_to_bluestore

1 similar comment
@guits
Copy link
Collaborator

guits commented Mar 6, 2020

jenkins test centos-non_container-filestore_to_bluestore

@dsavineau dsavineau added the DNM Do NOT merge label Mar 6, 2020
If the filestore configuration was using a dedicated journal with either
a partition or a LV/VG then we need to reuse this for bluestore DB.

When filestore is using a raw devices then we shouldn't destroy
everything (data + journal) but only data otherwise the journal
partition won't exist anymore.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1790479

Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
(cherry picked from commit 535da53)
@dsavineau dsavineau changed the title filestore-to-bluestore: reuse dedicated journal (bp #5034) [skip ci] filestore-to-bluestore: reuse dedicated journal (bp #5034) Mar 6, 2020
@dsavineau dsavineau force-pushed the mergify/bp/stable-4.0/pr-5034 branch from ef8b90e to 6ddbe59 Compare March 6, 2020 16:31
@dsavineau dsavineau changed the title [skip ci] filestore-to-bluestore: reuse dedicated journal (bp #5034) filestore-to-bluestore: reuse dedicated journal (bp #5034) Mar 6, 2020
@dsavineau
Copy link
Contributor

jenkins test centos-non_container-filestore_to_bluestore

@dsavineau
Copy link
Contributor

jenkins test centos-container-filestore_to_bluestore

@dsavineau dsavineau changed the title filestore-to-bluestore: reuse dedicated journal (bp #5034) [skip ci] filestore-to-bluestore: reuse dedicated journal (bp #5034) Mar 6, 2020
@dsavineau dsavineau force-pushed the mergify/bp/stable-4.0/pr-5034 branch from 6ddbe59 to 32cf8c2 Compare March 6, 2020 19:09
@dsavineau dsavineau changed the title [skip ci] filestore-to-bluestore: reuse dedicated journal (bp #5034) filestore-to-bluestore: reuse dedicated journal (bp #5034) Mar 6, 2020
@dsavineau
Copy link
Contributor

jenkins test centos-non_container-filestore_to_bluestore

@dsavineau
Copy link
Contributor

jenkins test centos-container-filestore_to_bluestore

@dsavineau dsavineau changed the title filestore-to-bluestore: reuse dedicated journal (bp #5034) [skip ci] filestore-to-bluestore: reuse dedicated journal (bp #5034) Mar 6, 2020
We only disable the ceph-osd services but not the ceph-volume lvm
services during the filestore to bluestore migration.

Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
(cherry picked from commit 38a683e)
@dsavineau dsavineau force-pushed the mergify/bp/stable-4.0/pr-5034 branch from 32cf8c2 to 739f59f Compare March 6, 2020 20:22
@dsavineau dsavineau changed the title [skip ci] filestore-to-bluestore: reuse dedicated journal (bp #5034) filestore-to-bluestore: reuse dedicated journal (bp #5034) Mar 6, 2020
@dsavineau dsavineau removed the DNM Do NOT merge label Mar 6, 2020
@dsavineau
Copy link
Contributor

jenkins test centos-non_container-filestore_to_bluestore

@dsavineau
Copy link
Contributor

jenkins test centos-container-filestore_to_bluestore

@guits
Copy link
Collaborator

guits commented Mar 12, 2020

jenkins test centos-non_container-filestore_to_bluestore

@guits
Copy link
Collaborator

guits commented Mar 12, 2020

failure seen here is not specific to this PR (unrelated)

@guits guits merged commit 957156c into stable-4.0 Mar 12, 2020
@guits guits deleted the mergify/bp/stable-4.0/pr-5034 branch March 12, 2020 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants