docker2podman: pull images from docker daemon #5280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsavineau
added
enhancement
DNM
|
we need #5237 first to test this |
dsavineau
changed the title
|
jenkins test centos-container-docker_to_podman |
dsavineau
changed the title
dsavineau
force-pushed
the
docker2podman_transfert_image
branch
from
f8d00db
to
2af3dbd
Compare
dsavineau
changed the title
|
jenkins test centos-container-docker_to_podman |
dsavineau
changed the title
dsavineau
force-pushed
the
docker2podman_transfert_image
branch
from
2af3dbd
to
a1d5aa3
Compare
dsavineau
changed the title
|
jenkins test centos-container-docker_to_podman |
dsavineau
changed the title
dsavineau
force-pushed
the
docker2podman_transfert_image
branch
from
a1d5aa3
to
fdd0336
Compare
dsavineau
changed the title
|
jenkins test centos-container-docker_to_podman |
|
check-github |
|
@chkumar246 your job is failing for unrelated reason, any chance you can take a look and fix it? We can't merge this patch because of that |
guits
previously approved these changes
Apr 24, 2020
dsavineau
changed the title
dsavineau
force-pushed
the
docker2podman_transfert_image
branch
from
fdd0336
to
fb40b54
Compare
dsavineau
changed the title
|
jenkins test centos-container-docker_to_podman |
|
@guits do you want to split this PR into two dedicated PR ? The second commit is associated to a BZ but the first commit is an enhancement. WDYT ? |
The docker2podman playbook only installs the podman package and updates
the systemd units with the right container_binary value.
We never pull the container image so if one service is restarted then
the container image will be pulled first before the service can start
which could cause longer downstream.
To avoid to download the container image from internet again we can just
pull it from the local docker daemon.
The container_{binding,package,service}_name variables are removed
because they are only used in the ceph-container-engine role which
isn't call in this playbook.
Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
The dashboard nodes (alertmanager, grafana, node-exporter, and prometheus) were not manage during the docker to podman migration. This adds the systemd container template of those services to a dedicated file (systemd.yml) in order to include it in the docker2podman playbook. This also adds the dashboard container images pull from docker to podman. Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1829389 Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
dsavineau
changed the title
dsavineau
force-pushed
the
docker2podman_transfert_image
branch
from
fb40b54
to
ac72424
Compare
dsavineau
changed the title
|
jenkins test centos-container-docker_to_podman |
guits
approved these changes
May 13, 2020
I think it's fine, I would backport this anyway |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docker2podman playbook only installs the podman package and updates
the systemd units with the right container_binary value.
We never pull the container image so if one service is restarted then
the container image will be pulled first before the service can start
which could cause longer downstream.
To avoid to download the container image from internet again we can just
pull it from the local docker daemon.
The container_{binding,package,service}_name variables are removed
because they are only used in the ceph-container-engine role which
isn't call in this playbook.
Signed-off-by: Dimitri Savineau dsavinea@redhat.com