Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph-rgw: use match instead of equalto from jinja2 #5341

Merged
merged 1 commit into from May 6, 2020

Conversation

dsavineau
Copy link
Contributor

The '==' jinja2 operator (or 'equalto') has been introduced in jinja2
2.8.
On EL7, jinja2 version is 2.7 so the operator isn't present creating
templating error like:

The error was: TemplateRuntimeError: no test named '=='

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1747206

Signed-off-by: Dimitri Savineau dsavinea@redhat.com

@dsavineau dsavineau requested a review from alimaredia May 6, 2020 17:35
@dsavineau dsavineau changed the title [skip ci] ceph-rgw: use match instead of equalto from jinja2 ceph-rgw: use match instead of equalto from jinja2 May 6, 2020
alimaredia
alimaredia previously approved these changes May 6, 2020
Copy link
Contributor

@alimaredia alimaredia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as it passes CI, lgtm.

@dsavineau
Copy link
Contributor Author

jenkins test centos-non_container-rgw_multisite

@dsavineau
Copy link
Contributor Author

jenkins test centos-container-rgw_multisite

The '==' jinja2 operator (or 'equalto') has been introduced in jinja2
2.8.
On EL7, jinja2 version is 2.7 so the operator isn't present creating
templating error like:

The error was: TemplateRuntimeError: no test named '=='

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1747206

Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
@dsavineau dsavineau changed the title ceph-rgw: use match instead of equalto from jinja2 [skip ci] ceph-rgw: use match instead of equalto from jinja2 May 6, 2020
@dsavineau dsavineau changed the title [skip ci] ceph-rgw: use match instead of equalto from jinja2 ceph-rgw: use match instead of equalto from jinja2 May 6, 2020
@dsavineau dsavineau requested a review from alimaredia May 6, 2020 17:58
@dsavineau
Copy link
Contributor Author

@alimaredia I've updated the PR because with the match operator we need to use ^$ to avoid matching a superset zone/zonegroup/realm

@dsavineau
Copy link
Contributor Author

jenkins test centos-non_container-rgw_multisite

@dsavineau
Copy link
Contributor Author

jenkins test centos-container-rgw_multisite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants