Commit on behalf of Daniel Parkes #5583
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the radosgw_frontend_port to take in account more than 1 RGW instance, in it’s original form 'radosgw_frontend_port': radosgw_frontend_port | int , it configured the 8080 port to all instances, with the following modification 'radosgw_frontend_port': radosgw_frontend_port | int + item|int we increase in 1 the port count. Removed the conditional check rgw_instances is undefined, this has to be checked in detail but this variable was never arriving undefined at this point of the playbook.
|
This error has nothing to do with the change. fatal: [rgw0]: FAILED! => changed=false |
added 2 commits
July 24, 2020 12:24
Signed-off-by: Raul <rmahique@redhat.com>
|
Why are you closing this ? https://bugzilla.redhat.com/show_bug.cgi?id=1859872 doesn't need to be fixed anymore ? |
|
it does, i think i closed by mistake |
|
I created another pull request: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the radosgw_frontend_port to take in account more than 1 RGW instance, in it’s original form 'radosgw_frontend_port': radosgw_frontend_port | int , it configured the 8080 port to all instances, with the following modification 'radosgw_frontend_port': radosgw_frontend_port | int + item|int we increase in 1 the port count.
Removed the conditional check rgw_instances is undefined, this has to be checked in detail but this variable was never arriving undefined at this point of the playbook.
Signed-off-by: Raul rmahique@redhat.com