shrink-osd: various fixes #5599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins test centos-non_container-shrink_osd_single |
|
jenkins test centos-container-shrink_osd_single |
|
jenkins test centos-non_container-shrink_osd_multiple |
|
jenkins test centos-container-shrink_osd_multiple |
|
jenkins test centos-non_container-shrink_osd_single |
1 similar comment
|
jenkins test centos-non_container-shrink_osd_single |
|
jenkins test centos-non_container-shrink_osd_multiple |
|
jenkins test centos-container-shrink_osd_single |
|
jenkins test centos-container-shrink_osd_multiple |
|
jenkins test centos-non_container-all_daemons |
guits
changed the title
guits
changed the title
guits
force-pushed
the
fix-shrink-osd
branch
2 times, most recently
from
edbcbba
to
f219421
Compare
guits
changed the title
This handles missing /etc/ceph/osd, by ensuring we actually found files in
`/etc/ceph/osd` before trying to slurp their content.
This also add a missing `| default(False)` to avoid fowlloing error:
```
fatal: [ceph01]: FAILED! =>
msg: |-
The conditional check 'ceph_osd_data_json[item.2]['encrypted'] | bool' failed. The error was: error while evaluating conditional (ceph_osd_data_json[item.2]['encrypted'] | bool): 'dict object' has no attribute 'encrypted'
```
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1862416
Signed-off-by: Benoît Knecht <bknecht@protonmail.ch>
guits
changed the title
|
jenkins test centos-container-shrink_osd_single |
|
jenkins test centos-container-shrink_osd_multiple |
|
jenkins test centos-non_container-shrink_osd_single |
|
jenkins test centos-non_container-shrink_osd_multiple |
dsavineau
approved these changes
Aug 4, 2020
guits
approved these changes
Aug 4, 2020
This was referenced Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles missing /etc/ceph/osd, by ensuring we actually found files in
/etc/ceph/osdbefore trying to slurp their content.This also add a missing
| default(False)to avoid fowlloing error:Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1862416
Signed-off-by: Benoît Knecht bknecht@protonmail.ch