rgw: support 1+ rgw instance in radosgw_frontend_port
#5613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guits
reviewed
Aug 4, 2020
| with_sequence: start=0 end={{ radosgw_num_instances|int - 1 }} | ||
| when: | ||
| - inventory_hostname in groups.get(rgw_group_name, []) | ||
| - rgw_instances is undefined |
There was a problem hiding this comment.
this has to be checked in detail but this variable was never arriving undefined at this point of the playbook.
did you manually set rgw_instances in your host_vars ?
you might want to add |
guits
requested changes
Aug 4, 2020
guits
changed the title
guits
force-pushed
the
set_radosgw_address_bug
branch
from
dd85a09
to
21fbc0c
Compare
Change the radosgw_frontend_port to take in account more than 1 RGW instance, in it's original form `radosgw_frontend_port: radosgw_frontend_port | int`, it configured the 8080 port to all instances, with the following modification `radosgw_frontend_port: radosgw_frontend_port | int + item|int` we increase in 1 the port count. Co-authored-by: Daniel Parkes <dparkes@redhat.com> Signed-off-by: raul <rmahique@redhat.com>
guits
force-pushed
the
set_radosgw_address_bug
branch
from
21fbc0c
to
f42d3e9
Compare
guits
changed the title
radosgw_frontend_port
|
jenkins test centos-non_container-all_daemons |
|
jenkins test centos-container-all_daemons |
|
@rmahique forget about my last comment, i've squashed them for you |
guits
approved these changes
Aug 10, 2020
guits
changed the title
radosgw_frontend_portradosgw_frontend_port
This was referenced Aug 11, 2020
guits
changed the title
radosgw_frontend_portradosgw_frontend_port
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nstance,
Commit on behalf of Daniel Parkes
Change the radosgw_frontend_port to take in account more than 1 RGW instance, in it’s original form
'radosgw_frontend_port': radosgw_frontend_port | int, it configured the 8080 port to all instances, with the following modification 'radosgw_frontend_port': radosgw_frontend_port | int + item|int we increase in 1 the port count.Signed-off-by: raul rmahique@redhat.com