[skip ci] adopt: various fixes #7080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guits
requested changes
Feb 7, 2022
asm0deuz
force-pushed
the
BZ2048734_cephadm_ssh_user
branch
2 times, most recently
from
9dd4233
to
31a62e2
Compare
guits
requested changes
Feb 7, 2022
asm0deuz
force-pushed
the
BZ2048734_cephadm_ssh_user
branch
from
31a62e2
to
f0d5c5a
Compare
guits
reviewed
Feb 8, 2022
fmount
suggested changes
Feb 8, 2022
|
Another weird behavior I found happens during the enrolling [1]: looks like the labels are not properly assigned and this is probably related to the gathered facts. [1] https://paste.opendev.org/show/812578/ |
asm0deuz
force-pushed
the
BZ2048734_cephadm_ssh_user
branch
2 times, most recently
from
6fdc5a9
to
7c7889c
Compare
guits
requested changes
Feb 9, 2022
asm0deuz
force-pushed
the
BZ2048734_cephadm_ssh_user
branch
3 times, most recently
from
04487a6
to
a6f85ff
Compare
guits
reviewed
Feb 10, 2022
guits
reviewed
Feb 10, 2022
asm0deuz
force-pushed
the
BZ2048734_cephadm_ssh_user
branch
2 times, most recently
from
65fddf7
to
50ae620
Compare
asm0deuz
force-pushed
the
BZ2048734_cephadm_ssh_user
branch
3 times, most recently
from
8c2e539
to
021bd3c
Compare
guits
reviewed
Feb 23, 2022
asm0deuz
force-pushed
the
BZ2048734_cephadm_ssh_user
branch
2 times, most recently
from
6f7a934
to
08bdbb2
Compare
By default cephadm uses root account to connect remotely to other nodes in the cluster. This change allows to choose another account. This commit also allows to use a dedicated subnet for cephadm mgmt. Signed-off-by: Teoman ONAY <tonay@redhat.com>
When using cluster custom names, cephadm commands are executed using the default admin keyring name which fails. Signed-off-by: Teoman ONAY <tonay@redhat.com>
When using group of group, the playbook will apply undesired labels on nodes. This commit fixes it by applying only the expected labels. Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2057528 Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
asm0deuz
force-pushed
the
BZ2048734_cephadm_ssh_user
branch
from
20654c6
to
c9f5ce3
Compare
guits
changed the title
guits
changed the title
|
jenkins test centos-container-cephadm_adopt |
1 similar comment
|
jenkins test centos-container-cephadm_adopt |
guits
approved these changes
Mar 3, 2022
This was referenced Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default cephadm uses root account to connect remotely
to other nodes in the cluster. This change allows to choose
another account.
Signed-off-by: Teoman ONAY tonay@redhat.com