Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip ci] adopt: fix rbd-mirror adoption #7084

Merged
merged 1 commit into from Feb 9, 2022
Merged

[skip ci] adopt: fix rbd-mirror adoption #7084

merged 1 commit into from Feb 9, 2022

Conversation

guits
Copy link
Collaborator

@guits guits commented Feb 9, 2022

We can't use {{ cephadm_cmd }} here because the monitors aren't yet adopted.
We must use {{ ceph_cmd }} instead.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1967440

Signed-off-by: Guillaume Abrioux gabrioux@redhat.com

@guits guits changed the title [skip ci] adopt: fix rbd-mirror adoption adopt: fix rbd-mirror adoption Feb 9, 2022
@guits
Copy link
Collaborator Author

guits commented Feb 9, 2022

jenkins test centos-container-adopt

@guits
Copy link
Collaborator Author

guits commented Feb 9, 2022

jenkins test centos-container-cephadm_adopt

@guits guits changed the title adopt: fix rbd-mirror adoption [skip ci] adopt: fix rbd-mirror adoption Feb 9, 2022
We can't use `{{ cephadm_cmd }}` here because the monitors aren't yet adopted.
We must use `{{ ceph_cmd }}` instead.
This also fixes some filters `| default()` (they must be moved before `| from_json()`)

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1967440

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
@guits guits changed the title [skip ci] adopt: fix rbd-mirror adoption adopt: fix rbd-mirror adoption Feb 9, 2022
@guits
Copy link
Collaborator Author

guits commented Feb 9, 2022

jenkins test centos-container-cephadm_adopt

@guits guits changed the title adopt: fix rbd-mirror adoption [skip ci] adopt: fix rbd-mirror adoption Feb 9, 2022
@guits guits changed the title [skip ci] adopt: fix rbd-mirror adoption adopt: fix rbd-mirror adoption Feb 9, 2022
@guits
Copy link
Collaborator Author

guits commented Feb 9, 2022

jenkins test centos-container-cephadm_adopt

@guits guits changed the title adopt: fix rbd-mirror adoption [skip ci] adopt: fix rbd-mirror adoption Feb 9, 2022
@guits guits merged commit 94e51d5 into master Feb 9, 2022
6 checks passed
@guits guits deleted the bz1967440 branch February 9, 2022 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant