New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace ip_version check with ansible test #7418
Conversation
|
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
|
@guits can you review this patch when you have the chance? |
|
@xbezdick why not set ip_version to ivp4? cephadm_mgmt_network shouldn't be used in the condition to chose between ipv4 or ipv6 |
|
jenkins test centos-non_container-update |
|
jenkins test centos-non_container-all_daemons |
|
jenkins test centos-non_container-switch_to_containers |
|
jenkins test centos-non_container-purge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that looks good to me, I don't see any issue with this patch.
I let @asm0deuz take a final look
|
jenkins test centos-non_container-all_daemons |
|
@xbezdick LGTM as well but could you sign-off your commit? Thx |
Instead of checking ip_version variable we should check the input address for ip version and select code path based on that. This solves ceph adoption with mixed ipv6 and ipv4 networks. Resolves: rhbz#2186226 Signed-off-by: Lukas Bezdicka <lbezdick@redhat.com>
|
As we found in rhbz#2207872, now that we use |
|
It's actually even more complicated. |
I see now, when I install the |
Instead of checking ip_version variable we should check the input address for ip version and select code path based on that.
This solves ceph adoption with mixed ipv6 and ipv4 networks.
Resolves: rhbz#2186226