Include rh_storage repo/installs when specified

[alfredodeza]

Before the repo configuration for ISOs for RH Storage was in a file that would be included only when:

- name: configure ceph yum repository
  include: redhat_ceph_repository.yml
  when: ceph_origin == 'upstream'

Which would not work for rh_storage. This PR normalizes using the same convention for install_rh_storage_on_debian to create a new install_rh_storage_on_redhat.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1339096

[andrewschoen]

I don't think you'll need to check ceph_stable_rh_storage anywhere in this file because the when statement that includes this file already does that check.

[alfredodeza]

test this please don't be ridiculous

[andrewschoen]

👍

[alfredodeza]

test this please

[alfredodeza]

test this please because these do not look related. @leseb mind browsing these changes?

[leseb]

Looks like we are still hitting, but only on CentOS:

"stderr": "Problem opening /dev/vdb for reading! Error is 2.\nThe specified file does not exist!\nProblem opening '' for writing! Program will now terminate.\nWarning! MBR not overwritten! Error is 2!\nProblem opening /dev/vdb for reading! Error is 2.\nThe specified file does not exist!\nProblem opening '' for writing! Program will now terminate.\nWarning! MBR not overwritten! Error is 2!", "stdout": "Information: Creating fresh partition table; will override earlier problems!\nNon-GPT disk; not saving changes. Use -g to override.\nInformation: Creating fresh partition table; will override earlier problems!\nNon-GPT disk; not saving changes. Use -g to override.", "stdout_lines": ["Information: Creating fresh partition table; will override earlier problems!", "Non-GPT disk; not saving changes. Use -g to override.", "Information: Creating fresh partition table; will override earlier problems!", "Non-GPT disk; not saving changes. Use -g to override.".

[leseb]

This is not needed because of the include already checks for RedHat.

[alfredodeza]

But the dependencies are different from redhat to centos, we have both:

• redhat_package_dependencies
• centos_package_dependencies

[leseb]

Right my bad.

[leseb]

test this please

[alfredodeza]

@leseb yeah those CentOS7 machines are coming without a disk from OVH :(

[alfredodeza]

test this please