Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Ubuntu Bionic globally #1022

Merged
merged 1 commit into from May 3, 2018
Merged

Add support for Ubuntu Bionic globally #1022

merged 1 commit into from May 3, 2018

Conversation

djgalloway
Copy link

Signed-off-by: David Galloway dgallowa@redhat.com

Copy link
Contributor

@alfredodeza alfredodeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK to me. However it is pretty hard to catch all of the places where this might fail because of an omission. I think we should just move forward and fix as things come up

@djgalloway
Copy link
Author

That was my thinking as well. I need to redeploy all the CI services first.

@alfredodeza
Copy link
Contributor

I'll let @tchaikov take a quick look before I merge tomorrow.

Signed-off-by: David Galloway <dgallowa@redhat.com>
@djgalloway
Copy link
Author

Just rebased

@djgalloway djgalloway changed the title DNM: Add support for Ubuntu Bionic globally Add support for Ubuntu Bionic globally May 3, 2018
@alfredodeza alfredodeza merged commit f9e97bf into master May 3, 2018
@alfredodeza alfredodeza deleted the wip-bionic branch May 3, 2018 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants