Modify scripts/{sync-pull,sign-rpms,sync-push} to handle ceph-iscsi #2243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Mick <dan.mick@redhat.com>
This allows signing ceph-iscsi packages Signed-off-by: Dan Mick <dan.mick@redhat.com>
Several sections are done only for the 'ceph' project (to accommodate ceph-iscsi, which has no debs, so doesn't need to find the most-populated distroversion or create debs, pull a tarball, etc.). Also drop el7. Signed-off-by: Dan Mick <dan.mick@redhat.com>
ceph-iscsi also needs a repo file created Drop el7 Add usage Signed-off-by: Dan Mick <dan.mick@redhat.com>
|
This requires ceph/ceph-container#2210 to use the new paths |
|
This was tested for constructing the release of ceph-iscsi 3.8 and ceph 18.2.3 |
2 tasks
yuriw
approved these changes
May 22, 2024
dmick
added a commit
to dmick/ceph
that referenced
this pull request
May 22, 2024
Support added to the release scripts (from ceph-build.git) to work for ceph-iscsi, so 'project' must be passed to these scripts, and will appear in the prerelease pathnames. See also ceph/ceph-build#2243 and ceph/ceph-container#2210 Signed-off-by: Dan Mick <dan.mick@redhat.com>
14 tasks
dmick
added a commit
to dmick/ceph
that referenced
this pull request
May 22, 2024
Support added to the release scripts (from ceph-build.git) to work for ceph-iscsi, so 'project' must be passed to these scripts, and will appear in the prerelease pathnames. See also ceph/ceph-build#2243 and ceph/ceph-container#2210 Signed-off-by: Dan Mick <dan.mick@redhat.com>
zdover23
pushed a commit
to zdover23/ceph
that referenced
this pull request
May 23, 2024
Support added to the release scripts (from ceph-build.git) to work for ceph-iscsi, so 'project' must be passed to these scripts, and will appear in the prerelease pathnames. See also ceph/ceph-build#2243 and ceph/ceph-container#2210 Signed-off-by: Dan Mick <dan.mick@redhat.com> (cherry picked from commit 7e64c63)
zdover23
pushed a commit
to zdover23/ceph
that referenced
this pull request
May 23, 2024
Support added to the release scripts (from ceph-build.git) to work for ceph-iscsi, so 'project' must be passed to these scripts, and will appear in the prerelease pathnames. See also ceph/ceph-build#2243 and ceph/ceph-container#2210 Signed-off-by: Dan Mick <dan.mick@redhat.com> (cherry picked from commit 7e64c63)
zdover23
pushed a commit
to zdover23/ceph
that referenced
this pull request
May 23, 2024
Support added to the release scripts (from ceph-build.git) to work for ceph-iscsi, so 'project' must be passed to these scripts, and will appear in the prerelease pathnames. See also ceph/ceph-build#2243 and ceph/ceph-container#2210 Signed-off-by: Dan Mick <dan.mick@redhat.com> (cherry picked from commit 7e64c63)
|
retest |
|
The test is failing, but there are no tests for these scripts (the test failure is unrelated). Merging. |
mkogan1
pushed a commit
to mkogan1/ceph
that referenced
this pull request
Aug 7, 2024
Support added to the release scripts (from ceph-build.git) to work for ceph-iscsi, so 'project' must be passed to these scripts, and will appear in the prerelease pathnames. See also ceph/ceph-build#2243 and ceph/ceph-container#2210 Signed-off-by: Dan Mick <dan.mick@redhat.com> (cherry picked from commit 7e64c63)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the tools and paths basically grow a "project" argument to distinguish ceph from ceph-iscsi.
In addition, drop el7, add vim modelines, and other minor cleanup.