Permalink
Browse files

bdi_register: add __printf verification, fix arg mismatch

__printf is useful to verify format and arguments.

Signed-off-by: Joe Perches <joe@perches.com>
Reviewed-by: Alex Elder <elder@inktank.com>
  • Loading branch information...
1 parent 83aff95 commit d2cc4dde9206aa2c7fb237aa689d3277cc070547 @JoePerches JoePerches committed with Alex Elder Nov 29, 2012
Showing with 2 additions and 1 deletion.
  1. +1 −1 fs/ceph/super.c
  2. +1 −0 include/linux/backing-dev.h
View
@@ -842,7 +842,7 @@ static int ceph_register_bdi(struct super_block *sb,
fsc->backing_dev_info.ra_pages =
default_backing_dev_info.ra_pages;
- err = bdi_register(&fsc->backing_dev_info, NULL, "ceph-%d",
+ err = bdi_register(&fsc->backing_dev_info, NULL, "ceph-%ld",
atomic_long_inc_return(&bdi_seq));
if (!err)
sb->s_bdi = &fsc->backing_dev_info;
@@ -114,6 +114,7 @@ struct backing_dev_info {
int bdi_init(struct backing_dev_info *bdi);
void bdi_destroy(struct backing_dev_info *bdi);
+__printf(3, 4)
int bdi_register(struct backing_dev_info *bdi, struct device *parent,
const char *fmt, ...);
int bdi_register_dev(struct backing_dev_info *bdi, dev_t dev);

0 comments on commit d2cc4dd

Please sign in to comment.