daemon-base: Add ceph-grafana-dashboards #1290
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed for full functionality of the mgr dashboard module. Signed-off-by: Zack Cerza <zack@redhat.com>
|
Please let me know if I made this change in the right place; as far as I know the package will only exist from nautilus on. |
ErwanAliasr1
suggested changes
Jan 14, 2019
There was a problem hiding this comment.
If you put that package in src/daemon-base/ that means that all releases will have to provide it. Including luminous/mimic/master.
Will you provide this package for each of this releases ?
If you only provide it to master then you'll have to override CEPH_BASE_PACKAGES in luminous & mimic
|
@zmc any news on this one ? |
fmount
referenced
this pull request
May 29, 2019
This is needed to install the ceph dashboard json files in `/etc/grafana/dashboards/ceph-dashboard/`. Closes: ceph/ceph-ansible#4026 Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
|
addressed in #1384 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for full functionality of the mgr dashboard module.
Signed-off-by: Zack Cerza zack@redhat.com