Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

variables_entrypoint.sh: improve logging #1408

Merged
merged 1 commit into from Jun 26, 2019
Merged

Conversation

guits
Copy link
Collaborator

@guits guits commented Jun 26, 2019

sosreport does not export logs from journald, so the idea here is to
have an alternative to retrieve logs in a containerized context.

Related ceph-ansible PR: ceph/ceph-ansible#4166

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1710548

Signed-off-by: Guillaume Abrioux gabrioux@redhat.com

guits added a commit to ceph/ceph-ansible that referenced this pull request Jun 26, 2019
related ceph-container PR: ceph/ceph-container#1408

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1710548

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
@dsavineau dsavineau added backport-stable-4.0 Backports for stable Nautilus branch enhancement labels Jun 26, 2019
guits added a commit to ceph/ceph-ansible that referenced this pull request Jun 26, 2019
related ceph-container PR: ceph/ceph-container#1408

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1710548

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
@guits guits changed the title entrypoint: improve logging [variables_entrypoint.sh]: improve logging Jun 26, 2019
guits added a commit to ceph/ceph-ansible that referenced this pull request Jun 26, 2019
related ceph-container PR: ceph/ceph-container#1408

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1710548

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
@guits guits force-pushed the guits-improve_logging branch 2 times, most recently from a1f65af to f9cf921 Compare June 26, 2019 14:03
@guits guits changed the title [variables_entrypoint.sh]: improve logging variables_entrypoint.sh: improve logging Jun 26, 2019
sosreport does not export logs from journald, so the idea here is to
have an alternative to retrieve logs in a containerized context.

Related ceph-ansible PR: ceph/ceph-ansible#4166

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1710548

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
@dsavineau dsavineau merged commit d6d1d9c into master Jun 26, 2019
@dsavineau dsavineau deleted the guits-improve_logging branch June 26, 2019 16:55
guits added a commit to ceph/ceph-ansible that referenced this pull request Jun 27, 2019
bindmount /var/log/ceph on all containers so it's possible to retrieve
logs from the host.

related ceph-container PR: ceph/ceph-container#1408

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1710548

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
guits added a commit to ceph/ceph-ansible that referenced this pull request Jun 27, 2019
bindmount /var/log/ceph on all containers so it's possible to retrieve
logs from the host.

related ceph-container PR: ceph/ceph-container#1408

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1710548

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
dsavineau pushed a commit to ceph/ceph-ansible that referenced this pull request Jun 28, 2019
bindmount /var/log/ceph on all containers so it's possible to retrieve
logs from the host.

related ceph-container PR: ceph/ceph-container#1408

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1710548

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
mergify bot pushed a commit to ceph/ceph-ansible that referenced this pull request Jun 28, 2019
bindmount /var/log/ceph on all containers so it's possible to retrieve
logs from the host.

related ceph-container PR: ceph/ceph-container#1408

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1710548

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit 33eed78)
dsavineau pushed a commit to ceph/ceph-ansible that referenced this pull request Jul 2, 2019
bindmount /var/log/ceph on all containers so it's possible to retrieve
logs from the host.

related ceph-container PR: ceph/ceph-container#1408

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1710548

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit 33eed78)
@fultonj
Copy link

fultonj commented Aug 28, 2019

@guits Can this get backported to 3.x?

@dsavineau
Copy link
Contributor

@fultonj If I remember correctly this solution wasn't possible to backport to luminous (see the discussion in the BZ)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-stable-4.0 Backports for stable Nautilus branch enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants