daemon/start_mon.sh: add mon without port value #1410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guits
approved these changes
Jun 27, 2019
dsavineau
force-pushed
the
ceph_mon_add_v2_v1
branch
2 times, most recently
from
691d3b8
to
83c4895
Compare
|
@leseb couldn't it be a breaking change for existing deployment where |
|
@guits do we allow that in ceph-ansible? |
|
@leseb yes, I guess using |
|
Even though we specify a different port, I don't think this will actually work, (the mon map does not have that port). If this is supposed to work in ceph-ansible then the mon endpoint should have that vars, I don't think it does. |
When bootstrapping an initial cluster, we don't need to add the mon to the monmap via 'ceph mon add' command. But when we want to scale up the monitors then we need it. Currently the new mon added will be out of quorum because the addr in the ceph config and in the monmap won't match. start_mon(): ceph --cluster ceph mon add xxx 192.168.100.5:3300 mon.xxx at v2:192.168.100.5:3300/0 already exists Even if the ceph conf uses v2+v1 then the new mon will have only v2 address configured in the monmap creating a conflict. 0 mon.xxx@0(probing) e3 monmap addrs for rank 4 changed, i am [v2:192.168.100.5:3300/0,v1:192.168.100.5:6789/0], monmap is v2:192.168.100.5:3300/0, respawning 0 mon.xxx@0(probing) e3 respawn Removing the port value on the 'ceph mon add' command allows to add a monitor with the msgr configuration defined in the ceph config. This change is nautilus+ only. Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1719013 Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1722066 Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
dsavineau
force-pushed
the
ceph_mon_add_v2_v1
branch
from
83c4895
to
10fed53
Compare
|
@dsavineau @guits [1] docker.io/ceph/daemon:bz1719013-nautilus-centos-7-x86_64 |
|
@fultonj is right, the scale up of the monitors was successful, but the scale up of rgw services failed |
guits
approved these changes
Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When bootstrapping an initial cluster, we don't need to add the mon
to the monmap via 'ceph mon add' command.
But when we want to scale up the monitors then we need it.
Currently the new mon added will be out of quorum because the addr
in the ceph config and in the monmap won't match.
start_mon(): ceph --cluster ceph mon add xxx 192.168.100.5:3300
mon.xxx at v2:192.168.100.5:3300/0 already exists
Even if the ceph conf uses v2+v1 then the new mon will have only v2
address configured in the monmap creating a conflict.
0 mon.xxx@0(probing) e3 monmap addrs for rank 4 changed, i am
[v2:192.168.100.5:3300/0,v1:192.168.100.5:6789/0], monmap is
v2:192.168.100.5:3300/0, respawning
0 mon.xxx@0(probing) e3 respawn
Removing the port value on the 'ceph mon add' command allows to add
a monitor with the msgr configuration defined in the ceph config.
This change is nautilus+ only.
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1719013
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1722066
Signed-off-by: Dimitri Savineau dsavinea@redhat.com