cephfs: implement getMetadataPool() with go-ceph #1578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nixpanic
added
enhancement
nixpanic
added this to In progress
in Use go-ceph for volume management operations
via automation
nixpanic
force-pushed
the
cephfs/go-ceph/getMetadataPool
branch
2 times, most recently
from
e34c60d
to
055c75b
Compare
|
This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏 |
nixpanic
force-pushed
the
cephfs/go-ceph/getMetadataPool
branch
from
055c75b
to
219c37d
Compare
|
/retest ci/centos/upgrade-tests-cephfs |
humblec
reviewed
Oct 19, 2020
Madhu-1
reviewed
Oct 20, 2020
nixpanic
force-pushed
the
cephfs/go-ceph/getMetadataPool
branch
from
219c37d
to
e012394
Compare
|
/retest ci/centos/upgrade-tests-cephfs |
Madhu-1
approved these changes
Oct 20, 2020
|
|
humblec
reviewed
Oct 20, 2020
| if err != nil { | ||
| util.ErrorLog(ctx, "could not list filesystems, can not fetch metadata pool for %s:", vo.FsName, err) | ||
| return "", err |
There was a problem hiding this comment.
@nixpanic dont we have to defer fsa here?
There was a problem hiding this comment.
no, there is no destructor for FSAdmin
There was a problem hiding this comment.
oh..ok .. its good to have.. We dont have to leave the connection behind.
humblec
approved these changes
Oct 20, 2020
ceph-csi-bot
force-pushed
the
cephfs/go-ceph/getMetadataPool
branch
from
e012394
to
2d00777
Compare
|
/retest ci/centos/mini-e2e-helm/k8s-1.19.2 |
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Fixes: ceph#1554 Signed-off-by: Niels de Vos <ndevos@redhat.com>
golang-ci suddenly complains about the following issue
internal/cephfs/util.go:41:1: directive `// nolint:unparam // todo:program values has to be revisited later` is unused for linter unparam (nolintlint)
// nolint:unparam // todo:program values has to be revisited later
^
Dropping the comment completely seems to fix it. Ideally
execCommandJSON() will get removed once the migration to go-ceph is
complete.
Signed-off-by: Niels de Vos <ndevos@redhat.com>
ceph-csi-bot
force-pushed
the
cephfs/go-ceph/getMetadataPool
branch
from
2d00777
to
9a7e4c7
Compare
|
/retest ci/centos/mini-e2e-helm/k8s-1.18.9 |
|
/retest ci/centos/upgrade-tests-rbd |
Use go-ceph for volume management operations
automation
moved this from In progress
to Done
Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce the number of
ceph fscommand executions, and use go-ceph with a cached/shared connection.Fixes: #1554
Do-Not-Merge: depends on #1545, #1581 and #1577, which need to get merged first