util: allow configuring VAULT_BACKEND for Vault connection #2307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nixpanic
added
enhancement
humblec
previously approved these changes
Jul 20, 2021
yati1998
approved these changes
Jul 20, 2021
|
/retest ci/centos/upgrade-tests-cephfs |
Madhu-1
previously approved these changes
Jul 21, 2021
|
@Mergifyio rebase |
nixpanic
force-pushed
the
rbd/encryption/VAULT_BACKEND
branch
from
a0fe391
to
870a624
Compare
|
Command
|
mergify
bot
dismissed stale reviews from humblec and Madhu-1
Pull request has been modified.
Madhu-1
approved these changes
Jul 21, 2021
humblec
approved these changes
Jul 22, 2021
|
@Mergifyio rebase |
It seems that the version of the key/value engine can not always be detected for Hashicorp Vault. In certain cases, it is required to configure the `VAULT_BACKEND` (or `vaultBackend`) option so that a successful connection to the service can be made. The `kv-v2` is the current default for development deployments of Hashicorp Vault (what we use for automated testing). Production deployments default to version 1 for now. Signed-off-by: Niels de Vos <ndevos@redhat.com>
nixpanic
force-pushed
the
rbd/encryption/VAULT_BACKEND
branch
from
870a624
to
e3fb2ea
Compare
|
Command
|
|
/retest ci/centos/mini-e2e-helm/k8s-1.19 |
Failed with #2264 |
|
@Mergifyio backport release-v3.3 |
|
Command
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the version of the key/value engine can not always be
detected for Hashicorp Vault. In certain cases, it is required to
configure the
VAULT_BACKEND(orvaultBackend) option so that asuccessful connection to the service can be made.
The
kv-v2is the current default for development deployments ofHashicorp Vault (what we use for automated testing). Production
deployments default to version 1 for now.
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)
/retest all: run this in case the CentOS CI failed to start/report any testprogress or results