cephfs: remove extra check for restore size #3183
Conversation
|
Adding DNM and converting it to draft as the discussion is going on for snapshot-size |
|
On Mon, Jun 13, 2022 at 11:51:55PM -0700, Madhu Rajanna wrote:
Looks like the cephfs snapshot size is buggy and it's getting
removed in ceph fs. we cannot get the size of the snapshot during the
CreateVolume call, so we cannot do any size check at CreateVolume to
check if the restore size is smaller or not.
If this is buggy, add a reference to the Ceph issue tracker please.
|
Done! |
|
/retest ci/centos/mini-e2e-helm/k8s-1.23 |
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
|
Removing DNM as discussed in the team meeting. we are good to consider this one. |
|
@nixpanic PTAL |
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
|
This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏 |
|
Resolved merge conflicts and rebased |
| if vol.BackingSnapshot { | ||
| if vol.Size != parentVol.Size { |
There was a problem hiding this comment.
@gman0 I am removing this check as it can cause a problem if the parent subvolume is resized after taking a snapshot, please check if am missing anything.
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
|
@Mergifyio rebase |
Looks like cephfs snapshot size is buggy and its getting removed in ceph fs. we cannot get the size of the snapshot during CreateVolume call, so we cannot do any size check at CreateVolume to check if the restore size is smaller or not. As we are removing this check it also fixes ceph#3147 but we dont have any validation at CSI level for smaller restore we need to depend on kubernetes external-provisioner for it. fixes: ceph#3147 Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
✅ Branch has been successfully rebased |
|
/retest ci/centos/k8s-e2e-external-storage/1.21 |
|
@Mergifyio requeue |
❌ This pull request head commit has not been previously disembarked from queue. |
|
/retest ci/centos/k8s-e2e-external-storage/1.23 |
|
/retest ci/centos/mini-e2e-helm/k8s-1.22 |
|
@Mergifyio requeue |
❌ This pull request head commit has not been previously disembarked from queue. |
|
/retest ci/centos/k8s-e2e-external-storage/1.23 |
|
@Mergifyio requeue |
❌ This pull request head commit has not been previously disembarked from queue. |
Looks like the cephfs snapshot size is buggy and it's getting removed in ceph fs. we cannot get the size of the snapshot during the CreateVolume call, so we cannot do any size check at CreateVolume to check if the restore size is smaller or not.
As we are removing this check it also fixes #3147 but we dont have any validation at the CSI level for smaller restore we need to depend on kubernetes external-provisioner for it.
fixes: #3147
ceph tracker https://tracker.ceph.com/issues/55822 to remove size from snapshot API.
Signed-off-by: Madhu Rajanna madhupr007@gmail.com