Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config upgrade from 2 to 3 #162

Merged
merged 1 commit into from Dec 18, 2019
Merged

Fix config upgrade from 2 to 3 #162

merged 1 commit into from Dec 18, 2019

Conversation

mikechristie
Copy link
Contributor

If there is no target defined we will crash when upgrading from to 2 to
3. This modifies the version 3 upgrade so we do not assume there will
always be a target defined.

If there is no target defined we will crash when upgrading from to 2 to
3. This modifies the version 3 upgrade so we do not assume there will
always be a target defined.

Signed-off-by: Mike Christie <mchristi@redhat.com>
Copy link

@dillaman dillaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm -- where did you hit this issue?

@mikechristie
Copy link
Contributor Author

The ansible people reported it:

ceph/ceph-ansible#4825 (comment)

Copy link
Contributor

@ricardoasmarques ricardoasmarques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikechristie mikechristie merged commit 8410cd8 into ceph:master Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants