From 555362e9b87addfd7af74cddd336a3fee5a7ae49 Mon Sep 17 00:00:00 2001 From: Casey Bodley Date: Thu, 31 Mar 2022 13:50:59 -0400 Subject: [PATCH 1/4] rgw: rgw_ops_log_rados is off by default Signed-off-by: Casey Bodley --- src/common/options/rgw.yaml.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/common/options/rgw.yaml.in b/src/common/options/rgw.yaml.in index 1e17bc04a2d3b..67d5c50b834cf 100644 --- a/src/common/options/rgw.yaml.in +++ b/src/common/options/rgw.yaml.in @@ -1450,7 +1450,7 @@ options: long_desc: If set, RGW will store ops log information in RADOS. fmt_desc: Whether the operations log should be written to the Ceph Storage Cluster backend. - default: true + default: false services: - rgw see_also: From 9236529bbbb7a358cdca883800b1d48f1d5e80fd Mon Sep 17 00:00:00 2001 From: Casey Bodley Date: Thu, 31 Mar 2022 13:53:15 -0400 Subject: [PATCH 2/4] rgw: add scary warning to long_desc of rgw_ops_log_rados Signed-off-by: Casey Bodley --- src/common/options/rgw.yaml.in | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/common/options/rgw.yaml.in b/src/common/options/rgw.yaml.in index 67d5c50b834cf..a1a3cc9c3f549 100644 --- a/src/common/options/rgw.yaml.in +++ b/src/common/options/rgw.yaml.in @@ -1447,7 +1447,10 @@ options: type: bool level: advanced desc: Use RADOS for ops log - long_desc: If set, RGW will store ops log information in RADOS. + long_desc: If set, RGW will store ops log information in RADOS. WARNING, + there is no automation to clean up these log entries, so by default they + will pile up without bound. This MUST NOT be enabled unless the admin has + a strategy to manage and trim these log entries with `radosgw-admin log rm`. fmt_desc: Whether the operations log should be written to the Ceph Storage Cluster backend. default: false @@ -1455,6 +1458,8 @@ options: - rgw see_also: - rgw_enable_ops_log + - rgw_log_object_name_utc + - rgw_log_object_name with_legacy: true # path to unix domain socket where ops log can go - name: rgw_ops_log_socket_path From 7fe4bf15563fe4f4f39f4395c91d2c877d53c266 Mon Sep 17 00:00:00 2001 From: Casey Bodley Date: Thu, 31 Mar 2022 13:54:16 -0400 Subject: [PATCH 3/4] rgw: enable rgw_ops_log_file_path by default Signed-off-by: Casey Bodley --- src/common/options/rgw.yaml.in | 4 +++- src/test/cli/ceph-conf/show-config.t | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/common/options/rgw.yaml.in b/src/common/options/rgw.yaml.in index a1a3cc9c3f549..a378c71ac877a 100644 --- a/src/common/options/rgw.yaml.in +++ b/src/common/options/rgw.yaml.in @@ -1480,8 +1480,10 @@ options: type: str level: advanced desc: File-system path for ops log. - long_desc: Path to file that RGW will log ops logs to. + long_desc: Path to file that RGW will log ops logs to. A cephadm deployment will automatically + rotate these logs under /var/log/ceph/. Other deployments should arrange for similar log rotation. fmt_desc: The file-system path for writing operations logs. + daemon_default: /var/log/ceph/ops-log-$cluster-$name.log services: - rgw see_also: diff --git a/src/test/cli/ceph-conf/show-config.t b/src/test/cli/ceph-conf/show-config.t index cfd723997c874..45405e4b7a079 100644 --- a/src/test/cli/ceph-conf/show-config.t +++ b/src/test/cli/ceph-conf/show-config.t @@ -2,5 +2,6 @@ admin_socket = /var/run/ceph/ceph-osd.0.asok log_file = /var/log/ceph/ceph-osd.0.log mon_debug_dump_location = /var/log/ceph/ceph-osd.0.tdump + rgw_ops_log_file_path = /var/log/ceph/ops-log-ceph-osd.0.log $ CEPH_ARGS="--fsid 96a3abe6-7552-4635-a79b-f3c096ff8b95" ceph-conf -n osd.0 --show-config -c /dev/null | grep fsid fsid = 96a3abe6-7552-4635-a79b-f3c096ff8b95 From 4045b7cb46c00464b66888a02c60af030329e699 Mon Sep 17 00:00:00 2001 From: Casey Bodley Date: Tue, 5 Apr 2022 17:20:22 -0400 Subject: [PATCH 4/4] PendingReleaseNotes for ops log backend Signed-off-by: Casey Bodley --- PendingReleaseNotes | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/PendingReleaseNotes b/PendingReleaseNotes index 10bd8ce5b5b3b..15b1deedbecdb 100644 --- a/PendingReleaseNotes +++ b/PendingReleaseNotes @@ -1,3 +1,9 @@ +>=18.0.0 + +* RGW's default backend for `rgw_enable_ops_log` changed from RADOS to file. + The default value of `rgw_ops_log_rados` is now false, and `rgw_ops_log_file_path` + defaults to "/var/log/ceph/ops-log-$cluster-$name.log". + >=17.0.0 * Filestore has been deprecated in Quincy, considering that BlueStore has been