Permalink
Browse files

tests: save 9 characters for asok paths

For vstart.sh powered tests, save 9 characters in the path name
by replacing testdir/test- with td/t-

60 characters imposed by jenkins
9 characters for src/test
5 characters for td/t-

33 left (instead of 24) for the test to create asok such as out/client.admin.25327.asok

Moving these files outside of the build directory is a bad idea because
tests should only create/use files within the builddir and not write
outside of this directory. Doing so would make things more complicated
for cleanup in case the test fail and create other problems as a
consequence (filling out disk space, conflicting directories between
runs etc.).

For ceph-helpers.sh tests replace testdir with td, saving 5 characters.
This is not strictly necessary but keeps the directory names consistent:
if the developer wants to get rid of all the test leftovers, it is
enough to remove the a single directory: td.

Fixes: http://tracker.ceph.com/issues/16014

Signed-off-by: Loic Dachary <loic@dachary.org>
  • Loading branch information...
1 parent db1a943 commit cd72ff9f746fe13a245324dce2aa457d3c876331 @ldachary ldachary committed Nov 18, 2016
Showing with 4 additions and 4 deletions.
  1. +1 −1 .gitignore
  2. +2 −2 qa/workunits/ceph-helpers.sh
  3. +1 −1 src/test/vstart_wrapper.sh
View
@@ -28,7 +28,7 @@ core
# Files generated by running tests
*.log
-/src/testdir
+/src/td
# specific local dir files
/build-doc
@@ -1457,7 +1457,7 @@ function test_wait_background() {
# @return 0 on success, 1 on error
#
function main() {
- local dir=testdir/$1
+ local dir=td/$1
shift
shopt -s -o xtrace
@@ -1496,7 +1496,7 @@ function run_tests() {
export CEPH_CONF=/dev/null
local funcs=${@:-$(set | sed -n -e 's/^\(test_[0-9a-z_]*\) .*/\1/p')}
- local dir=testdir/ceph-helpers
+ local dir=td/ceph-helpers
for func in $funcs ; do
$func $dir || return 1
@@ -19,7 +19,7 @@
source $CEPH_ROOT/qa/workunits/ceph-helpers.sh
export CEPH_VSTART_WRAPPER=1
-export CEPH_DIR="${TMPDIR:-$PWD}/testdir/test-$CEPH_PORT"
+export CEPH_DIR="${TMPDIR:-$PWD}/td/t-$CEPH_PORT"
export CEPH_DEV_DIR="$CEPH_DIR/dev"
export CEPH_OUT_DIR="$CEPH_DIR/out"

0 comments on commit cd72ff9

Please sign in to comment.