New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msg/AsyncMessenger: remove unused method #10125

Merged
merged 1 commit into from Feb 20, 2017

Conversation

Projects
None yet
4 participants
@stiopaa1
Contributor

stiopaa1 commented Jul 4, 2016

Change the return type of function send_keepalive to void. It
doesn't make sense to return constant value(zero).

Signed-off-by: Michal Jarzabek stiopa@gmail.com

@tchaikov tchaikov added the cleanup label Jul 5, 2016

@yuyuyu101

This comment has been minimized.

Member

yuyuyu101 commented Sep 8, 2016

I suggest we remove these lines since it doesn't have user

msg/AsyncMessenger: remove unused function
Signed-off-by: Michal Jarzabek <stiopa@gmail.com>

@liewegas liewegas added cleanup and removed cleanup common labels Sep 18, 2016

@ghost

This comment has been minimized.

ghost commented Nov 21, 2016

jenkins test this please (no logs)

@tchaikov tchaikov added the needs-qa label Feb 18, 2017

@tchaikov tchaikov requested a review from yuyuyu101 Feb 18, 2017

@tchaikov tchaikov changed the title from msg/AsyncMessenger: change return type to void to msg/AsyncMessenger: remove unused method "send_keepalive()" Feb 20, 2017

@tchaikov tchaikov changed the title from msg/AsyncMessenger: remove unused method "send_keepalive()" to msg/AsyncMessenger: remove unused method Feb 20, 2017

@tchaikov

This comment has been minimized.

@tchaikov tchaikov merged commit 0423b61 into ceph:master Feb 20, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment