rgw: fix multi-delete query param parsing. #10189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multi-delete is triggered by a query parameter on POST, but there are multiple valid ways of representing it, and Ceph should accept ANY way that has the query parameter set, regardless of what value or absence of value. This caused the RubyGem aws-sdk-v1 to break, and has been present since multi-delete was first added in commit 0a1f4a9, for the bobtail release. Fixes: http://tracker.ceph.com/issues/16618 Signed-off-by: Robin H. Johnson <robin.johnson@dreamhost.com> (cherry picked from commit a7016e1)
smithfarm
changed the title
|
Marking DNM until master commit #10187 is merged and backport staged. |
smithfarm
changed the title
smithfarm
added a commit
that referenced
this pull request
Jul 18, 2016
Reviewed-by: Nathan Cutler <ncutler@suse.com>
smithfarm
added a commit
that referenced
this pull request
Jul 24, 2016
Reviewed-by: Nathan Cutler <ncutler@suse.com>
|
@yehudasa This PR passed an rgw suite with some valgrind-related failures that appear harmless - see http://tracker.ceph.com/issues/15895#note-19 Do you think this PR is ready to merge? |
|
@smithfarm ack |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport: http://tracker.ceph.com/issues/16698
Multi-delete is triggered by a query parameter on POST, but there are
multiple valid ways of representing it, and Ceph should accept ANY way
that has the query parameter set, regardless of what value or absence of
value.
This caused the RubyGem aws-sdk-v1 to break, and has been present since
multi-delete was first added in commit 0a1f4a9, for the bobtail
release.
Fixes: http://tracker.ceph.com/issues/16618
Signed-off-by: Robin H. Johnson robin.johnson@dreamhost.com
(cherry picked from commit a7016e1)