osd/ReplicatedPG: remove redundant check for balance/localize read #10209

Merged
merged 1 commit into from Dec 12, 2016

Projects

None yet

5 participants

@runsisi
Contributor
runsisi commented Jul 8, 2016

given an op if the PG is a replica and is able to handle it, then the
op must have the BALANCE_READS or LOCALIZE_READS flag(s) set, otherwise
the op was misdirected and had been rejected at the every beginning of
the function.

Signed-off-by: runsisi runsisi@zte.com.cn

runsisi osd/ReplicatedPG: remove redundant check for balance/localize read
given an op if the PG is a replica and is able to handle it, then the
op must have the BALANCE_READS or LOCALIZE_READS flag(s) set, otherwise
the op was misdirected and had been rejected at the every beginning of
the function.

Signed-off-by: runsisi <runsisi@zte.com.cn>
614b04f
@xiexingguo
Contributor

LGTM

@dachary
Member
dachary commented Nov 21, 2016

jenkins test this please (jenkins stuck)

@dachary
Member
dachary commented Nov 22, 2016

jenkins test this please (asok now fixed in master)

@xiexingguo xiexingguo was assigned by dachary Nov 23, 2016
@dachary

on behalf of xiexingguo

@xiexingguo
Contributor

@athanatos Can you double check this?

@athanatos athanatos added the needs-qa label Nov 28, 2016
@athanatos
Member

lgtm

@tchaikov tchaikov self-assigned this Dec 9, 2016
@tchaikov tchaikov merged commit 51342e8 into ceph:master Dec 12, 2016

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
@tchaikov tchaikov assigned athanatos and unassigned tchaikov and xiexingguo Dec 12, 2016
@runsisi runsisi deleted the runsisi:sisi-wip-remove-redundant-check branch Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment