New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon: remove the redudant jugement in paxosservice is_writeable function #10240

Merged
merged 1 commit into from Mar 7, 2017

Conversation

Projects
None yet
5 participants
@songbaisen

songbaisen commented Jul 11, 2016

mon: remove the redudant jugement in paxosservice is_writeable function

From

      !is_proposing() &&
      !is_proposing() &&
     (paxos->is_active() || paxos->is_updating() || paxos->is_writing())&& have_pending&&
     (paxos->is_active() || paxos->is_updating() || paxos->is_writing())

To

      !is_proposing() &&
     (paxos->is_active() || paxos->is_updating() || paxos->is_writing())&& have_pending

Signed-off-by: song baisen song.baisen@zte.com.cn

songbaisen
mon: remove the redudant jugement in paxosservice is_writeable function
   From
	  !is_proposing() &&
	  !is_proposing() &&
     (paxos->is_active() || paxos->is_updating() || paxos->is_writing())&& have_pending&&
     (paxos->is_active() || paxos->is_updating() || paxos->is_writing())
   To
	  !is_proposing() &&
     (paxos->is_active() || paxos->is_updating() || paxos->is_writing())&& have_pending

Signed-off-by: song baisen <song.baisen@zte.com.cn>
@ghost

This comment has been minimized.

ghost commented Nov 21, 2016

jenkins test this please (jenkins stuck)

@liewegas

This comment has been minimized.

Member

liewegas commented Feb 3, 2017

this is clearly correct on its face, but i'm not sure why we have both is_writeable() and is_write_ready(). @jecluis ?

@tchaikov tchaikov self-assigned this Feb 4, 2017

@yuriw yuriw merged commit 0541218 into ceph:master Mar 7, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment