New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: clean unuse code in cls_statelog_check_state #10260

Merged
merged 1 commit into from May 11, 2017

Conversation

Projects
None yet
5 participants
@weiqiaomiao
Contributor

weiqiaomiao commented Jul 12, 2016

Signed-off-by: weiqiaomiao wei.qiaomiao@zte.com.cn

@weiqiaomiao

This comment has been minimized.

Contributor

weiqiaomiao commented Jul 30, 2016

retest this please

rgw:clean unuse code in cls_statelog_check_state
Signed-off-by: weiqiaomiao <wei.qiaomiao@zte.com.cn>

@mattbenjamin mattbenjamin self-assigned this Sep 9, 2016

@@ -279,19 +279,10 @@ static int cls_statelog_check_state(cls_method_context_t hctx, bufferlist *in, b
return -EINVAL;
}
string obj_index;

This comment has been minimized.

@mattbenjamin

mattbenjamin Sep 9, 2016

Contributor

@weiqiaomiao it certainly looks clear that even if cls_cxx_map_get_val were being used for a side effect, the same logic is executed in get_existing_entry(), with no intervening logic

@oritwas

This comment has been minimized.

Contributor

oritwas commented Apr 3, 2017

@mattbenjamin , ping

@liewegas liewegas changed the title from rgw:clean unuse code in cls_statelog_check_state to rgw: clean unuse code in cls_statelog_check_state May 1, 2017

@liewegas

This comment has been minimized.

Member

liewegas commented May 1, 2017

@cbodley

This comment has been minimized.

@cbodley cbodley merged commit 74ddaa5 into ceph:master May 11, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment