Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
common/ceph_context.cc: Use CEPH_DEV to reduce logfile noise #10384
changed the title from
Only alert for dangerous features if running with NDEBUG
[DNM] Only alert for dangerous features if running with NDEBUG
Nov 21, 2016
genuine error at https://jenkins.ceph.com/job/ceph-pull-requests/14601/console
Is that a plan?
referenced this pull request
Mar 28, 2017
What about instead setting an environment variable (CEPH_DEV=1 or CEPH_DEV_UNSAFE=1)? That way vstart.sh can just set it and all the annoying warnings will go away, but production deployments (regardless of how the binary was built) will still be noisy. I'm not sure I like the idea of compiling out the warnings entirely, even for debug builds, as debug builds can also get deployed for various reasons.