Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon/Monitor.h: add const to member function #10412

Merged
merged 1 commit into from Mar 27, 2017

Conversation

Projects
None yet
3 participants
@stiopaa1
Copy link
Contributor

stiopaa1 commented Jul 23, 2016

Signed-off-by: Michal Jarzabek stiopa@gmail.com

@@ -586,7 +586,7 @@ class Monitor : public Dispatcher,

public:
epoch_t get_epoch();
int get_leader() { return leader; }
int get_leader() const { return leader; }
const set<int>& get_quorum() { return quorum; }

This comment has been minimized.

Copy link
@tchaikov

tchaikov Jul 24, 2016

Contributor

@stiopaa1 could you do this sort of cleanup in batches. for example, add const in to the should-be-const methods of a class in a commit? to avoid too many merge commit? for example, in this commit we can also mark the get_quorum() method as const.

@liewegas liewegas added cleanup and removed cleanup common labels Sep 18, 2016

@tchaikov

This comment has been minimized.

Copy link
Contributor

tchaikov commented Mar 20, 2017

@stiopaa1 ping?

mon/Monitor.h: add const to member functions
Signed-off-by: Michal Jarzabek <stiopa@gmail.com>

@stiopaa1 stiopaa1 force-pushed the stiopaa1:mon_monitorh_addConstToGetLeader branch from 57ee7eb to 49ee693 Mar 26, 2017

@stiopaa1

This comment has been minimized.

Copy link
Contributor Author

stiopaa1 commented Mar 26, 2017

@tchaikov
I've modified the pull request

@tchaikov tchaikov added the mon label Mar 27, 2017

@tchaikov tchaikov merged commit a965e02 into ceph:master Mar 27, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.