msg/async: remove static member variable #10440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msgr is part of libcommon. and the later is linked into both libcephfs and librados. and hence into cephfs.so and rados.so. that's why we have double free. Fixes: http://tracker.ceph.com/issues/16686 Signed-off-by: Kefu Chai <kchai@redhat.com>
|
lgtm |
|
Reviewed-by: |
|
@jcsp this change works for me. could you help to check if it fixes your issue or not? |
|
@tchaikov , this fix works for me in my local setup. I was able to run the VolumeClient tests using vstart_runner. And thanks for the explanation here, http://permalink.gmane.org/gmane.comp.file-systems.ceph.devel/32519 |
|
@tchaikov looks good to me, thanks |
|
(I haven't tried it personally but I see that @ajarr has, which is enough for me) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
msgr is part of libcommon. and the later is linked into both libcephfs
and librados. and hence into cephfs.so and rados.so. that's why we have
double free.
Fixes: http://tracker.ceph.com/issues/16686
Signed-off-by: Kefu Chai kchai@redhat.com