New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fs: Mantle: A Programmable Metadata Load Balancer #10887
Conversation
michaelsevilla
commented
Aug 26, 2016
- Design/Motivation presented at August CDM
- Testing: mds: add tests for mantle (programmable balancer) ceph-qa-suite#1145
- Relies on the Lua source used in Lua object class support #7338 (that PR is also pending discussion on ceph-devel)
|
||
#define dout_subsys ceph_subsys_mds | ||
#define dout_subsys ceph_subsys_mds_balancer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we want this: iirc the --debug-mds flag isn't a prefixish thing, so this change will silence all the balancer and migrator logs for people who currently set --debug-mds
This looks to be exactly what was discussed at the last CDM, so all of my comments are just detail things. At a high level: Does #7338 need poking along somehow? |
You can either add more commits (and rebase later before merge) or just do a straight history-squashing rebase. Usually we leave comments on the "files changed" view (not individual commits) so that they survive a rebase, but I mistakenly put some on commits here -- my fault if they get lost in a rebase. |
Luckily Github finally fixed that nonsense, at least as long as you navigate from the PR view into the commit (not sure if you just go straight to a commit). You can tell it's working because all the comments are on the diff, not on a commit. ;) Personally I prefer commits prefixed with "SQUASH" that are intended to be rebase, as it makes life easier on the reviewer when there are follow-up comments, but that may just be me. |
This is good to go now from my point of view (apologies @michaelsevilla for delay). Please could you do a quick rebase as something else has touched CMakeLists.txt in the meantime |
Introduces Mantle, a programmable metadata load balancer. Policies for making migration decisions are written in Lua but the Migrator and Balancer modules still do fragmentation and migration. If the Lua balancer fails, control falls back to the original balancer implementation. Signed-off-by: Michael Sevilla <mikesevilla3@gmail.com>
- add docs and sample balancer (greedy-spill) Signed-off-by: Michael Sevilla <mikesevilla3@gmail.com>
- fix legacy encoding in mds map and add balancer to dumps - fix blocking rados read and remove temporary files - fix beacon message spamming Signed-off-by: Michael Sevilla <mikesevilla3@gmail.com>
5f67c19
to
5cc43cf
Compare
Done -- @batrick: could you send me info on the scaling tests? |