Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
fs: Mantle: A Programmable Metadata Load Balancer #10887
changed the title from
Mantle: A Programmable Metadata Load Balancer
fs: Mantle: A Programmable Metadata Load Balancer
Aug 28, 2016
You can either add more commits (and rebase later before merge) or just do a straight history-squashing rebase.
Usually we leave comments on the "files changed" view (not individual commits) so that they survive a rebase, but I mistakenly put some on commits here -- my fault if they get lost in a rebase.
Luckily Github finally fixed that nonsense, at least as long as you navigate from the PR view into the commit (not sure if you just go straight to a commit). You can tell it's working because all the comments are on the diff, not on a commit. ;)
Personally I prefer commits prefixed with "SQUASH" that are intended to be rebase, as it makes life easier on the reviewer when there are follow-up comments, but that may just be me.