New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rados: check for negative return value of rados_create_with_context() as its comment put #10893

Merged
merged 1 commit into from Apr 23, 2017

Conversation

Projects
None yet
3 participants
@yonghengdexin735
Contributor

yonghengdexin735 commented Aug 26, 2016

rados.init_with_context returned value is '<=0'

Signed-off-by: zhang.zezhu zhang.zezhu@zte.com.cn

tools/rados/rados:fixup the judgment value
Signed-off-by: zhang.zezhu <zhang.zezhu@zte.com.cn>
@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Oct 29, 2016

librados::Rados::init_with_context() calls rados_create_with_context(), which returns 0 on success.

@ghost ghost added bug fix tools labels Nov 23, 2016

@ghost

This comment has been minimized.

ghost commented Nov 23, 2016

@yonghengdexin735 please explain in the commit message why it is a bug to fail when the return value is a positive integer

@tchaikov tchaikov added cleanup and removed bug fix labels Apr 14, 2017

@tchaikov tchaikov changed the title from tools/rados/rados:fixup the judgment value to rados: check for negative return value of rados_create_with_context() as its comment put Apr 14, 2017

@tchaikov tchaikov self-assigned this Apr 21, 2017

@liewegas liewegas merged commit d764b56 into ceph:master Apr 23, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment