Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librbd: potential double-unwatch of watch handle upon error #10974

Merged
merged 1 commit into from Sep 6, 2016

Conversation

Projects
None yet
2 participants
@dillaman
Copy link
Contributor

commented Sep 4, 2016

Fixes: http://tracker.ceph.com/issues/17210
Signed-off-by: Jason Dillaman dillaman@redhat.com

@trociny trociny self-assigned this Sep 4, 2016

trociny pushed a commit that referenced this pull request Sep 4, 2016

Mykola Golub
Merge branch 'wip-17210' into wip-mgolub-testing
 librbd: potential double-unwatch of watch handle upon error #10974
@dillaman

This comment has been minimized.

Copy link
Contributor Author

commented Sep 5, 2016

Still hitting an issue: http://pulpito.ceph.com/jdillaman-2016-09-04_16:08:56-rbd-wip-jd-testing---basic-smithi/400108

Watch error returned -ENOENT since image was deleted -- once the image was closed, it attempted to unwatch an already unwatched handle.

librbd: potential double-unwatch of watch handle upon error
Fixes: http://tracker.ceph.com/issues/17210
Signed-off-by: Jason Dillaman <dillaman@redhat.com>

@dillaman dillaman force-pushed the dillaman:wip-17210 branch from a8022fd to 1068ded Sep 5, 2016

@dillaman

This comment has been minimized.

Copy link
Contributor Author

commented Sep 5, 2016

@trociny update pushed that recognizes that any errors from a rewatch imply the watch is unregistered

trociny pushed a commit that referenced this pull request Sep 5, 2016

Mykola Golub
Merge branch 'wip-17210' into wip-mgolub-testing
librbd: potential double-unwatch of watch handle upon error #10974
@trociny

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2016

retest this please

@trociny

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2016

lgtm

@trociny trociny merged commit 9a95536 into ceph:master Sep 6, 2016

1 of 2 checks passed

default Build finished.
Details
Signed-off-by all commits in this PR are signed
Details

@dillaman dillaman deleted the dillaman:wip-17210 branch Sep 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.