New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbd-mirror: force-promoted image will remain R/O until rbd-mirror daemon restarted #11090

Merged
merged 7 commits into from Sep 24, 2016

Conversation

Projects
None yet
2 participants
@dillaman
Contributor

dillaman commented Sep 15, 2016

@dillaman

This comment has been minimized.

Contributor

dillaman commented Sep 15, 2016

There is an unrelated memory corruption issue within rbd-mirror on master -- need to fix that first before testing and merging this PR

@trociny trociny self-assigned this Sep 16, 2016

@trociny

This comment has been minimized.

Contributor

trociny commented Sep 16, 2016

@dillaman Does #11104 fix the memory corruption issue you mention here and [DNM] prefix can be removed?

trociny pushed a commit that referenced this pull request Sep 16, 2016

Mykola Golub
Merge branch 'wip-16974' into wip-mgolub-testing
rbd-mirror: force-promoted image will remain R/O until rbd-mirror daemon restarted #11090
@dillaman

This comment has been minimized.

Contributor

dillaman commented Sep 16, 2016

@trociny Yes, so far so good.

@dillaman dillaman changed the title from [DNM] rbd-mirror: force-promoted image will remain R/O until rbd-mirror daemon restarted to rbd-mirror: force-promoted image will remain R/O until rbd-mirror daemon restarted Sep 16, 2016

@trociny

This comment has been minimized.

Contributor

trociny commented Sep 19, 2016

@dillaman "force promote" functional test passes locally for me but regularly fails on teuthology:

http://pulpito.ceph.com/trociny-2016-09-17_15:04:54-rbd-wip-mgolub-testing---basic-smithi/
http://pulpito.ceph.com/trociny-2016-09-17_15:04:37-rbd-wip-mgolub-testing---basic-mira/
http://pulpito.ceph.com/trociny-2016-09-17_15:04:21-rbd-wip-mgolub-testing---basic-vps/
http://pulpito.ceph.com/trociny-2016-09-17_15:04:04-rbd-wip-mgolub-testing---basic-vps/

Note, I rose debugging level for rbd-mirror daemon in the qa-suite config, so you might find useful data in cluster1-client.mirror.*.log files.

It looks I don't see image replayer handle_promoted handler being fired on tethology.

@dillaman

This comment has been minimized.

Contributor

dillaman commented Sep 19, 2016

@trociny Looks like journal::JournalMetadata::allocate_tag doesn't send out an update notification, so a forced promotion on an idle image would never be detected.

@dillaman dillaman force-pushed the dillaman:wip-16974 branch from 5eceee8 to 80f5e41 Sep 19, 2016

@dillaman

This comment has been minimized.

Contributor

dillaman commented Sep 19, 2016

@trociny repushed

trociny pushed a commit that referenced this pull request Sep 20, 2016

Mykola Golub
Merge branch 'wip-16974' into wip-mgolub-testing
rbd-mirror: force-promoted image will remain R/O until rbd-mirror daemon restarted #11090

trociny pushed a commit that referenced this pull request Sep 21, 2016

Mykola Golub
Merge branch 'wip-16974' into wip-mgolub-testing
rbd-mirror: force-promoted image will remain R/O until rbd-mirror daemon restarted #11090
@trociny

This comment has been minimized.

Contributor

trociny commented Sep 23, 2016

@dillaman Could you please rebase?

dillaman added some commits Sep 13, 2016

qa/workunits/rbd: new mirroring forced promotion test
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
journal: expose ability to retrieve partial tag list
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
qa/workunits/rbd: fix remove mirrored image race conditions
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
librbd: unify journal event callbacks into single interface
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
librbd: helper class for quiescing in-flight async ops
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
librbd: new journal listener event for force promotion
Fixes: http://tracker.ceph.com/issues/16974
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
journal: send update notification when tag allocated
Signed-off-by: Jason Dillaman <dillaman@redhat.com>

@dillaman dillaman force-pushed the dillaman:wip-16974 branch from 80f5e41 to f1cd613 Sep 23, 2016

@dillaman

This comment has been minimized.

Contributor

dillaman commented Sep 23, 2016

@trociny rebase pushed

@trociny

This comment has been minimized.

Contributor

trociny commented Sep 24, 2016

lgtm

@trociny trociny merged commit 9aab326 into ceph:master Sep 24, 2016

2 checks passed

Signed-off-by all commits in this PR are signed
Details
default Build finished.
Details

@dillaman dillaman deleted the dillaman:wip-16974 branch Sep 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment