New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: remove a redundant judgement in rgw_rados.cc:delete_obj. #11124

Merged
merged 1 commit into from Jul 13, 2017

Conversation

Projects
None yet
5 participants
@zhangsw
Contributor

zhangsw commented Sep 19, 2016

The value of the 'removed' is just the same as 'r>=0'. We can merge the two
judgement and remove the var 'removed'. Because the delete_obj is always called when
we delete obj from ceph, remove the judgement may gain a little improvement.

Signed-off-by: Zhang Shaowen zhangshaowen@cmss.chinamobile.com

rgw: remove a redundant judgement in rgw_rados.cc:delete_obj.The valu…
…e of

the 'removed' is just the same as 'r>=0'. We can merge the two
judgement and remove the var 'removed'.

Signed-off-by: Zhang Shaowen <zhangshaowen@cmss.chinamobile.com>
@mattbenjamin

This comment has been minimized.

Contributor

mattbenjamin commented Nov 19, 2016

@zhangsw I guess should just see test suite run

@oritwas oritwas self-assigned this Apr 3, 2017

@yuriw

This comment has been minimized.

@yehudasa

lgtm

@yehudasa yehudasa merged commit d95b521 into ceph:master Jul 13, 2017

3 of 4 checks passed

make check (arm64) Build triggered. sha1 is merged.
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment