jewel: librados: memory leaks from ceph::crypto (WITH_NSS) #11409

Merged
merged 1 commit into from Oct 14, 2016

Projects

None yet

4 participants

@cbodley @ldachary cbodley common: only call crypto::init once per CephContext
Fixes: http://tracker.ceph.com/issues/17205

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 9dfc153)
5d0e2f8
@dachary dachary self-assigned this Oct 11, 2016
@dachary dachary added this to the jewel milestone Oct 11, 2016
@dachary
Member
dachary commented Oct 14, 2016

@oritwas does this backport look good to merge ? It passed the rados (http://tracker.ceph.com/issues/17487#note-12), upgrade/jewel-x and upgrade/hammer-x (http://tracker.ceph.com/issues/17487#note-15) suites (except for two bugs that are, I believe, unrelated)

@oritwas oritwas was assigned by dachary Oct 14, 2016
@oritwas
Contributor
oritwas commented Oct 14, 2016

lgtm

@dachary dachary merged commit 4bcc21b into ceph:jewel Oct 14, 2016

2 checks passed

Signed-off-by all commits in this PR are signed
Details
default Build finished.
Details
@theanalyst theanalyst changed the title from jewel: librados memory leaks from ceph::crypto (WITH_NSS) to "jewel: librados: memory leaks from ceph::crypto (WITH_NSS)" Nov 17, 2016
@theanalyst theanalyst changed the title from "jewel: librados: memory leaks from ceph::crypto (WITH_NSS)" to jewel: librados: memory leaks from ceph::crypto (WITH_NSS) Nov 17, 2016
@liupan1111
Contributor

@dachary, this is a good fix. But have one question: is it better to set this init_crypto as private function, and be called inside the CephContext construction func?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment