os/bluestore: traverse buffer_map in reverse order when spliting BufferSpace #11468

Merged
merged 5 commits into from Oct 13, 2016

Projects

None yet

2 participants

@xiexingguo
Contributor

No description provided.

xiexingguo added some commits Oct 13, 2016
@xiexingguo xiexingguo os/bluestore: fix tips when adding buffer to cache
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
c701dd6
@xiexingguo xiexingguo os/bluestore: kill bluestore_shared_blob_hash_table_size_ratio
Which is depreciated by ceph@7260166#diff-6519c151b74b5a9355a697be278a4382

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
f538a7b
@xiexingguo xiexingguo common/config_opts: comment nit
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
0721e84
@liewegas liewegas was assigned by xiexingguo Oct 13, 2016
xiexingguo added some commits Oct 13, 2016
@xiexingguo xiexingguo os/bluestore: traverse buffer_map in reverse order
Which is more efficient.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
98677bd
@xiexingguo xiexingguo os/bluestore: add checking to catch unspecified compression algorithm
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
4262859
@liewegas
Member

Why is going in reverse more efficient?

- p->second->end() <= pos) {
- dout(30) << __func__ << " skip " << *p->second << dendl;
- ++p;
- }
@xiexingguo
xiexingguo Oct 13, 2016 Contributor

@liewegas
So we can avoid the skip process above, especially if we have to skip all.

@liewegas
Member
@liewegas liewegas merged commit 3ad8ccc into ceph:master Oct 13, 2016

2 checks passed

Signed-off-by all commits in this PR are signed
Details
default Build finished.
Details
@xiexingguo xiexingguo deleted the xiexingguo:xxg-wip-bluestore-1013 branch Oct 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment